Jetty HTTP client integration with WebClient [SPR-15092]

[spring-projects-issues]

Brian Clozel opened SPR-15092 and commented

Both implementations could take WebSocketClient implementations as examples of how to deal with backpressure with each library. The configuration model should also copy the current arrangement in WebSocketClient implementations, since each library deals with client instances and configuration objects in a different way.

---

Issue Links:

• JDK 11 HttpClient integration with WebClient [SPR-16469] #21014 JDK 11 HttpClient integration with WebClient
• Upgrade to Jetty reactive HTTP client 1.0.1 [SPR-17124] #21661 Upgrade to Jetty reactive HTTP client 1.0.1
• Add ClientHttpConnector for Apache Http-async-client [SPR-16341] #20888 Add ClientHttpConnector for Apache Http-async-client
• Leverage Jetty BOM [SPR-17058] #21596 Leverage Jetty BOM
• Add JettyResourceFactory [SPR-17179] #21715 Add JettyResourceFactory

Referenced from: pull request #1783, and commits spring-projects/spring-boot@f74dd7d

0 votes, 7 watchers

[spring-projects-issues]

Rossen Stoyanchev commented

Looks like there is now a Jetty ReactiveStreams HTTP Client. Perhaps we can try this for 5.0 still?

[spring-projects-issues]

Sébastien Deleuze commented

No commit for 5 month on jetty-reactive-httpclient, so given the early stage of that project I am not sure we should work on this for 5.1 ... Any thoughts Rossen Stoyanchev?

[spring-projects-issues]

Rossen Stoyanchev commented

Considering it exposes a Reactive Streams API, it should be relatively low effort (and risk) from our end. Certainly worth a quick experiment I think. Good point about the lack of activity. We should least indicate our intention (Jetty mailing list perhaps?) and ask whether they still plan to keep this effort up if we start filing issues and providing feedback.

[spring-projects-issues]

Akram commented

is there any update on this? If not then I suggest to revisit the documentation to specify that WebClient only supports Netty rightnow

[spring-projects-issues]

Rossen Stoyanchev commented

I'm scheduling for 5.1 RC1 since we do intend to give it a try at least.

[spring-projects-issues]

Simone Bordet commented

@Rossen, lack of activity is due to the fact that it's a wrapper around Jetty's HttpClient which is stable.
We are happy to improve the reactive wrapper if it needs to, and we definitely want to maintain it.

[spring-projects-issues]

Rossen Stoyanchev commented

(y)

[spring-projects-issues]

Sébastien Deleuze commented

I have a draft implementation with green tests for WebClientIntegrationTests and SseIntegrationTests, except WebClientIntegrationTests#shouldSendLargeTextFile with is failing. I have raised jetty-project/jetty-reactive-httpclient#3 with a repro project on Jetty side to ask for a fix.

[spring-projects-issues]

Sébastien Deleuze commented

Latest status update:

• The issue about WebClientIntegrationTests#shouldSendLargeTextFile has been fixed
• Jetty RS HTTP client now implements RS TCK tests for its Processor and Publisher implementations!
• I have polished implementation based on Simone feedback
• The main TODO is on buffer interrop, it works with buffer copy but fails with Mono when using ByteBuffer wrapping. It may be due to the deferred chunk release due to DataBufferUtils#join. I am currently discussing with Simone about that.

[spring-projects-issues]

Sébastien Deleuze commented

Pull request submitted, please send me your feedback.

[spring-projects-issues]

Sébastien Deleuze commented

Note that Jetty RS Client supports HTTP/2.

We should be able to add HTTP/2 tests at some point since Jetty RS client supports h2c and OkHttp MockServer 3.11 is going to support it as well. Another solution would be to make these tests only active when running Java9+, but that's not ideal especially with parameterized tests.