CssLinkResourceTransformer is incompatible with FixedVersionStrategy VersionResourceResolver [SPR-13727]

[spring-projects-issues]

Michael Russo opened SPR-13727 and commented

When attempting to use Spring MVC 4.1's web static resource handling outlined in this blog post, and choosing to use the VersionResourceResolver's FixedVersionStrategy, the automatically-configured CssLinkResourceTransformer will corrupt relative path URLs in CSS resources.

A resource such as "../images/logo.png" will be converted to an incorrect URL "<version>/../images/logo.png".

A known workaround for this issue is to use the ContentVersionStrategy instead of FixedVersionStrategy.

---

Affects: 4.1.8, 4.2.3

Reference URL: http://stackoverflow.com/questions/28875565/versionresourceresolver-breaks-css-relative-urls

Issue Links:

• CssLinkResourceTransformer is incompatible with ContentVersionStrategy when using Caching [SPR-14597] #19166 CssLinkResourceTransformer is incompatible with ContentVersionStrategy when using Caching
• Improvement suggestions to the ResourceTransformerChain [SPR-13806] #18379 Improvement suggestions to the ResourceTransformerChain

Referenced from: commits c226753, f53d01b

Backported to: 4.1.9

0 votes, 6 watchers

[spring-projects-issues]

Juergen Hoeller commented

Michael Russo, could you please give the most recent 4.2.4.BUILD-SNAPSHOT a try and let us know whether it works for you? The release is still two weeks away but I'd be great to verify upfront.

Juergen

[spring-projects-issues]

Marc Vanbrabant commented

Hi @juergen.hoeller - we can't use 4.2.4-BUILD-SNAPSHOT at the moment, but I have overriden your changes into our VersionStrategy and can confirm this also fixes the issue we're seeing with src: url("../fonts/notoserif-regular.eot");

[spring-projects-issues]

Juergen Hoeller commented

Cool, thanks for the feedback!

[spring-projects-issues]

Marc Vanbrabant commented

Any chance this patch can get into 4.1.x branch by the way?

[spring-projects-issues]

Juergen Hoeller commented

I was wondering about that myself... Since I'm currently doing a few backports to 4.1.9 already, I'll add this right away.

Juergen

[spring-projects-issues]

Michael Russo commented

@Juergen Hoeller, I was able to test with latest 4.2.4.BUILD-SNAPSHOT and verified that the issue was resolved. Using the FixedVersionStrategy, CssLinkResourceTransformer did not produce incorrect URLs for these relative path resources.

[spring-projects-issues]

Juergen Hoeller commented

Good to hear - thanks for the feedback!

Juergen

[spring-projects-issues]

Felix Kurth commented

It does not work if the relative url does not start with a "."

An example from jquery-ui.css

url("images/ui-bg_flat_100_ffffff_40x100.png")

still doesn't work.

[spring-projects-issues]

Brian Clozel commented

Hi Felix Kurth, thanks for this report!

I've disabled the processing of relative URLs altogether for the FixedVersionStrategy.
I think that even for "." relative URLs, this can lead to inconsistent prefixes.

If your "/css/jquery-ui.css" imports "images/ui.png", should we rewrite it as "version/images/ui.png" or "/css/version/images/ui.png" or "/version/css/images/ui.png"? Depending on your configuration, you could argue one or the other. Also, one could still do the following "./images/../../something.png".

I haven't found a consistent, clear behavior for those cases and I tend to think that the ContentVersionStrategy is a better fit in those cases.

Let me know what you think!

[spring-projects-issues]

Felix Kurth commented

Disabling the CssLinkResourceTransformer would have been a workaround for me, but this seems not possible without wiring the whole resolver chain manually.

It schould be possible to disable the CssLinkTransformer easily.
I would expect that an empty element:

<mvc:transformers >
</mvc:transformers>

means no transformers, and no "default" implicit ones.
i tried to disable auto registration

<mvc:resource-chain resource-cache="false" auto-registration="false" >

But i was not able to wire up the chain myself.

So my current solution is to exclude certain paths

<mvc:resources mapping="/resources/**" location="/, classpath:/META-INF/web-resources/"   >
    <mvc:resource-chain resource-cache="false"  >
        <mvc:resolvers >
            <mvc:version-resolver >
                <mvc:fixed-version-strategy patterns="/images/*.png" version="." />
                <mvc:fixed-version-strategy patterns="/../**" version="." />
                <mvc:fixed-version-strategy patterns="/**" version="#{'${Version}' + '${BuildNumber}' }" />
            </mvc:version-resolver>
        </mvc:resolvers>
    </mvc:resource-chain>
</mvc:resources>

Also for these cases, there should be a NoVersionStrategy available with its configuration:

<mvc:no-version-strategy patterns="/images/*.png" />

[spring-projects-issues]

Brian Clozel commented

Felix Kurth,

I'm resolving this issue right now because I believe your use case asks for more discussion, improvements and probably a repro case. Not that I think your concerns aren't relevant. Quite the opposite, I think they deserve their own issue and that we should close this one for the upcoming release (tomorrow).

Feel free to create a new issue and summarize your concern + copy/paste your last comment.
Or I can create one for you if you'd like.

In any case, I'd like to continue that discussion because your last comment points to several possible directions.

Thanks,

[spring-projects-issues]

Sean Carroll commented

I think there might be a regression in 4.3.X. When using 4.2.5 this works as intended but when upgrading to 4.3.2 it appears to encounter this same issue. Is there anything I should provide to confirm a regression bug for 4.3? Is it better to open a separate issue?

[spring-projects-issues]

Sean Carroll commented

Oops, not a regression as I'm using a content version strategy so it looks like a separate issue.

[spring-projects-issues]

Brian Clozel commented

Sean Carroll, is this similar to #19166?
If not, please create a separate ticket describing the problem and how to reproduce it. Thanks!