Revisit RedirectView's use of getCurrentWebApplicationContext() [SPR-13346]

[spring-projects-issues]

Juergen Hoeller opened SPR-13346 and commented

Since 3.1, RedirectView falls back to a ContextLoader.getCurrentWebApplicationContext() check to determine the ServletContext for building a RequestContext, which in turn gets used to retrieve the current RequestDataValueProcessor (if any). This doesn't seem to be the best possible arrangement, since the ServletContext is just used to retrieve the root WebApplicationContext... when we actually started with a current WebApplicationContext to begin with! Also, there is HttpServletRequest.getServletContext() since Servlet 3.0... even if there is probably no benefit in using that one here, it's generally preferable to a WebApplicationContext.getServletContext() lookup.

---

Affects: 4.2 GA

Issue Links:

• RequestDataValueProcessor not called in RedirectView [SPR-8770] #13413 RequestDataValueProcessor not called in RedirectView
• Provide a SpringConstraintValidatorFactory variant for use with validation.xml [SPR-13327] #17912 Provide a SpringConstraintValidatorFactory variant for use with validation.xml

Referenced from: commits 4314da9

[spring-projects-issues]

Juergen Hoeller commented

Revised through the introduction of RequestContextUtils.findWebApplicationContext.

Juergen