StandardServletMultipartResolver should support MaxUploadSizeExceededException against common servers [SPR-9294]

[spring-projects-issues]

Marten Deinum opened SPR-9294 and commented

Currently all exceptions thrown by the standard multipart support lead to the generic MultipartException. It would be nice if, like the CommonsMultipartResolver, there could be differentiated between a general exception or a MaxUploadSizeExceededException.

Probably not an easy task as it depends on the container how it is handled and which exception is thrown.

For tomcat it is:

org.apache.tomcat.util.http.fileupload.FileUploadBase$FileSizeLimitExceededException.

---

Affects: 3.1.1

Issue Links:

• CommonsMultipartFile.getOriginalFilename() should be able to preserve header-specified filename as-is [SPR-14613] #19180 CommonsMultipartFile.getOriginalFilename() should be able to preserve header-specified filename as-is
• CommonsMultipartResolver should explicitly convert FileSizeLimitExceededException next to SizeLimitExceededException [SPR-14638] #19204 CommonsMultipartResolver should explicitly convert FileSizeLimitExceededException next to SizeLimitExceededException

Referenced from: commits 1922f03

[spring-projects-issues]

Juergen Hoeller commented

Tomcat may also throw a related exception in case of the total request size exceeded: org.apache.commons.fileupload.FileUploadBase$SizeLimitExceededException: the request was rejected because its size (...) exceeds the configured maximum (...)

Jetty throws an IllegalStateException of the following kind: java.lang.IllegalStateException: Multipart Mime part file exceeds max filesize

So I guess we could at least do some educated guessing: If the exception class name or message contains the keywords "size" and "exceed", we throw the more specific MaxUploadSizeExceededException instead of our general MultipartException...

[spring-projects-issues]

Juergen Hoeller commented

The harder part is determining the actual size limits: They are available from the associated Servlet 3.0 MultipartConfig object, but unfortunately that's not accessible anywhere other than during a programmatic Servlet registration. We could nevertheless allow for passing it to the StandardServletMultipartResolver, e.g. in a web application initializer implementation or in a Spring Boot setup variant.

[spring-projects-issues]

Juergen Hoeller commented

I've rolled this in for 5.0 RC1 now, based on "size" and "exceed" keywords being detected, simply stubbing the maximum file size with -1 to indicate that it's not known. For richer exception reporting, we still recommend CommonsMultipartResolver.