"depends-on" attribute not working for dynamic language bean [SPR-8625]

[spring-projects-issues]

Michael Ottati opened SPR-8625 and commented

In attempting to refactor a bean from a statically compiled groovy script to a dynamically compiled one, I made the following change to my context.xml.

ORIGINAL

<bean id="routeBuilder" depends-on="routeModelExtender"
    class="org.openehealth.tutorial.SampleRouteBuilder">
</bean>

MODIFIED

<lang:groovy id="routeBuilder" depends-on="routeModelExtender"
             script-source="classpath:DynamicGroovyRouteBuilder.groovy">
</lang:groovy>

The code contained in DynamicGroovyRouteBuilder was an exact copy of the groovy script that was statically compiled. Upon testing this new configuration, it failed. The failure was at first cryptic however upon further examination I determined that the root cause of the failure was due to the fact that the bean my groovy script was dependent upon had not been instantiated.

I was able to correct the problem by declaring the dependency in a slightly different way. Instead of relying on the "depends-on" attribute, I added a property element to the dynamic language bean which referenced the bean I depended upon. The resulting definition did work.

WORKING

<lang:groovy id="routeBuilder"
             script-source="classpath:DynamicGroovyRouteBuilder.groovy">
    <lang:property name="routeModelExtender" ref="routeModelExtender"/>
</lang:groovy>

I am attaching a simple project that demonstrates the problem. Within the test case there are three tests:

StaticTest             Original working configuration with statically compiled groovy
DynamicDependsOnTest   Failure case
DynamicRefTest         Fix described above.

When these tests are run individually they work as described. When the tests are run together, for instance when running them with the mvn "test" goal they fail. The failure is described in this thread:

http://forum.springsource.org/showthread.php?100699-Unit-Test-Issue-ContextConfiguration-Multiple-AppContext-Files-amp-Autowiring

I have attached a test case that demonstrates the bug.

---

Affects: 3.0.5

Attachments:

• SpringDependencyBug.tgz (24.32 kB)

Referenced from: commits spring-attic/spring-framework-issues@b5326cc

[spring-projects-issues]

Michael Ottati commented

I negleted to mention in the original description that the way I deterined that the dependency was not being honored, was to place a trace breakpoint in:

org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean()

In the DynamicLanguageDependsOnTest, the "routeModelExtender" bean is never created by this method prior to the creation of the DynamicGroovyRouteBuilder bean.

In the two test cases that work, the "routeModelExtender" bean is created prior to the creation of the DynamicGroovyRouteBuilder bean.

[spring-projects-issues]

Chris Beams commented

Hi Michael,

I've just committed the project attached here at https://github.com/SpringSource/spring-framework-issues/tree/master/SPR-8625

Unfortunately, I am unable to build and run the tests due to this error during dependency resolution:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 42.512s
[INFO] Finished at: Fri Nov 18 15:04:54 PST 2011
[INFO] Final Memory: 7M/81M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project SPR-8625: Could not resolve dependencies for project org.springframework.issues:SPR-8625:jar:1.0.0-SNAPSHOT: Failed to collect dependencies for [org.openehealth.ipf.platform-camel:platform-camel-hl7:jar:2.2.0 (compile), org.apache.camel:camel-jetty:jar:2.6.0 (compile), ca.uhn.hapi:hapi-structures-v22:jar:1.0 (compile), ca.uhn.hapi:hapi-structures-v25:jar:1.0 (compile), org.springframework:spring-test:jar:3.0.5.RELEASE (test), junit:junit:jar:4.8.2 (test)]: Failed to read artifact descriptor for net.sf.saxon:saxon:jar:9.1.0.8: Could not transfer artifact net.sf.saxon:saxon:pom:9.1.0.8 from/to jboss (http://repository.jboss.com/maven2): Access denied to: http://repository.jboss.com/maven2/net/sf/saxon/saxon/9.1.0.8/saxon-9.1.0.8.pom -> [Help 1]

Could you look into this, ideally providing a patch that allows proper resolution to occur? If you'd like to actually submit this change against the github repository linked above,
just read these instructions to understand how it works: https://github.com/SpringSource/spring-framework-issues#readme

Thanks!

[spring-projects-issues]

Michael Ottati commented

Chris:

I am sorry I have gone so long without responding. I suspect that I never saw the notification that you had posted a comment. I only learned of it today when refering to this issue to try to remember how I put it together.

I believe the problem you are having with the Maven build has to do with the fact that somehow one of the dependencies has been deprecated. See this URL: http://mavenhub.com/mvn/deprecated/net.sf.saxon/saxon/9.1.0.8

If you add the following stanza to the repository section, I believe you should be able to get this to compile.

<repository>
    <id>JBOSS</id>
    <name>JBoss Repository</name>
    <url>https://repository.jboss.org/nexus/content/repositories/deprecated</url>
</repository>

If you post an additional comment and do not get a response from me, please feel free to look me up in your company DB, I work for your parent company.

I am truely sorry for letting this remain unanswered for so long.

Regards,

Michael

[spring-projects-issues]

Michael Ottati commented

When adding the repository that I mentioned in my April 2nd comment, were you able to reproduce this problem?

[spring-projects-issues]

Chris Beams commented

Hi Michael,

Haven't gotten to this yet, but I will give it a try and let you know.

[spring-projects-issues]

Juergen Hoeller commented

It looks like the depends-on attribute simply didn't get parsed by our ScriptBeanDefinitionParser which takes a lang:* element and translates it into a BeanDefinition object... We didn't have a depends-on attribute there originally, and it seems that its addition to the xsd happened without also adding corresponding code in the parser.

As of 3.2.2, we do parse that attribute now. Feel free to give it a try.

Juergen

[spring-projects-issues]

Michael Ottati commented

Juergen:

Thank you for the update. Since posting this issue, I have switched employers and hence email addresses. I never received an update notification for that reason. I logged back on today for another reason and noticed your activity. Sadly I am unable to figure out how to change my email ID within Confluence and may have to establish a new ID.

Your explanation is perfectly logical and I am going to believe that what you have described works. Unfortunately I am about to go on a 2 week holiday and will not have the opportunity to verify this any time soon.

Thanks,

Michael