Clean up ignored JMX tests [SPR-8089]

[spring-projects-issues]

Sam Brannen opened SPR-8089 and commented

Summary

Most (all?) JMX tests are based on JUnit 3.8; some incorrectly attempt to use JUnit 4's @Ignore annotation. Furthermore, some of these ignored tests actually work.

Caveat

The JMX test suite requires the presence of the jmxremote_optional.jar in order to avoid the "Unsupported protocol: jmxmp" error.

Further Resources

• EBR-349

• jmxremote_optional.jar can be acquired from Oracle in the JMX Remote API 1.0.1_04 Reference Implementation download.

---

Issue Links:

• Make "timed" and other environment-sensitive tests optional [SPR-8458] #13104 Make "timed" and other environment-sensitive tests optional ("depends on")
• Install jmxremote_optional.jar in JVM used for Spring CI builds [SPR-8093] #12748 Install jmxremote_optional.jar in JVM used for Spring CI builds ("depends on")
• org.springframework.jmx.export.NotificationListenerTests is marked @Ignore but extends TestCase in 3.0.x branch [SPR-8587] #13231 org.springframework.jmx.export.NotificationListenerTests is marked @Ignore but extends TestCase in 3.0.x branch

1 votes, 1 watchers

[spring-projects-issues]

Sam Brannen commented

Postponed until #12748 is resolved.

[spring-projects-issues]

Sam Brannen commented

I re-enabled the ignored JMX tests, and the following CI build succeeded:

https://build.springsource.org/browse/SPR-TRUNKQUICK-3680/

So it looks like everything is working!

[spring-projects-issues]

Chris Beams commented

Hi Sam,

My apologies for this, but per the commit comment below, I've reopened this issue and reverted the related changes. This is something we can revisit in 3.2 once we have a mechanism for running certain tests only on the CI server (like timed tests, for example).

I have created #13104 to track making tests like this optional; and have marked this issue as depending on it and assigned to myself for 3.2.

Of course if you have a strong argument why this must be enabled now despite the consequences, please let me know.

commit cc814519c8c5b943a2f5bb3950b2dde97db854bf
Author: Chris Beams <cbeams@vmware.com>
Date:   Thu Jun 16 14:12:19 2011 +0800

    Revert "Re-enable ignored JMX tests"
    
    As of SPR-8093, jmxremote_optional.jar is present on the build
    server in jre/lib/ext, but it is not by default present on local
    developer / user machines, meaning that the build ends up broken
    by default.
    
    Issue: SPR-8089, SPR-8093, SPR-8458

[spring-projects-issues]

Chris Beams commented

commit 9a48c10dcb903d3410b1114e432a48d62752b526
Author: Chris Beams <cbeams@vmware.com>
Date:   Tue Feb 26 16:24:43 2013 +0100

    Segregate tests that depend on the jmxmp: protocol
    
    This commit introduces TestGroup#JMXMP and adds assumptions to related
    tests accordingly. These tests require the jmxoptional_remote jar on the
    classpath, and are run nightly in the SPR-PERF build.
    
    Issue: SPR-8089

commit 10648942c34385d5d64b23e0c9d875d8b03d0d15
Author: Chris Beams <cbeams@vmware.com>
Date:   Tue Feb 26 16:21:21 2013 +0100

    Update AbstractMBeanServerTests hierarchy to JUnit 4
    
    This commit lays the groundwork for introducing TestGroup#JMXMP and
    related assumptions in select JMX-related tests in a subsequent commit;
    JUnit assumptions require JUnit 4+ to function properly, so the entire
    AbstractMBeanServerTests hierarchy must be moved over to JUnit 4+ style.
    
    Issue: SPR-8089

commit 55caf7bdb0b418d64967f057832eba40de7ff825
Author: Chris Beams <cbeams@vmware.com>
Date:   Tue Feb 26 16:10:23 2013 +0100

    Improve diagnostics for invalid testGroup values

commit cbe03093ba2529b07ea897945c3a9e5eeac946d0
Author: Chris Beams <cbeams@vmware.com>
Date:   Tue Feb 26 16:09:16 2013 +0100

    Revert "Revert "Re-enable ignored JMX tests""
    
    This reverts commit cc814519c8c5b943a2f5bb3950b2dde97db854bf.
    
    Issue: SPR-8089
    Conflicts:
        spring-context/src/test/java/org/springframework/jmx/access/RemoteMBeanClientInterceptorTestsIgnore.java
        spring-context/src/test/java/org/springframework/jmx/support/ConnectorServerFactoryBeanTestsIgnore.java