Change logging level to info in PropertiesLoaderSupport when logging message that resource is not found and ignoreResourceNotFound is true [SPR-7772]

[spring-projects-issues]

Stevo Slavić opened SPR-7772 and commented

Please change logging level to info in PropertiesLoaderSupport when logging message that resource is not found and ignoreResourceNotFound is set to true. By default ignoreResourceNotFound is set to false and developer has to explicitly set it to true - thus being aware of the behavior and consequences. This message is currently logged at warning logging level which IMO is too much, creates unnecessary noise, and makes sys admins nervous.

---

Affects: 3.0.5

Reference URL: http://forum.springsource.org/showthread.php?t=97681

Attachments:

• SPR-7772.patch (1.20 kB)

Issue Links:

• Improve logging for development (DEBUG vs TRACE) [SPR-16946] #21485 Improve logging for development (DEBUG vs TRACE) ("duplicates")

6 votes, 4 watchers

[spring-projects-issues]

Stevo Slavić commented

Attaching [^SPR-7772.patch] which changes mentioned logging level. Patch also includes enhancement, if ignoreResourceNotFound is true and resource does not exist (checked using spring.core.io.Resource.exists), then it gets skipped without attempt to load it and without any exceptions being thrown - message is logged in this case also, at info level.

[spring-projects-issues]

Mauro Molinari commented

I strongly agree with this issue reporting. If I said "ignore resources you don't find", why should PropertiesLoaderSupport warn me about not found resources? As of now, it isn't "ignoring" them, it is just going ahead all the same.

PropertiesLoaderSupport is especially used as PropertiesFactoryBean to configure a chain in properties resolution that allows for easy customization and overriding: so, it's absolutely normal that some (customized) properties files may not be found in the chain: it's very annoying and misleading to always have those warning entries in the application log.

Please fix this, it should also be straightforward!

[spring-projects-issues]

Sébastien Deleuze commented

Duplicates #21485 which is already fixed.