formMultiSelect macro in spring.ftl causes freemarker.template.TemplateException [SPR-7721]

[spring-projects-issues]

Jakub Głuszecki opened SPR-7721 and commented

formMultiSelect macro from spring.ftl causes following exception:

freemarker.template.TemplateException: Expected collection or sequence. list evaluated instead to freemarker.template.SimpleScalar on line 368, column 12 in spring.ftl.

This is the problematic line:

<#assign isSelected = contains(status.value?default([""]), value)>

status.value returns String instead of a Collection
(value is converted to String in AbstractPropertyBindingResult#formatFieldValue)
status.actualValue should be used instead.

---

Affects: 3.0.4, 3.0.5, 3.1 RC1

Referenced from: commits 61a5ab9, bfabd58

2 votes, 2 watchers

[spring-projects-issues]

Ramon Buckland commented

I can confirm this bug still exists in 3.0.6.RELEASE.

This affects formMultiSelect and formCheckboxes as these both deal with lists of values.

Below are the changes against the 3.0.6 spring.ftl - org/springframework/web/servlet/view/freemarker/spring.ftl

249c249
< <#assign isSelected = contains(status.value?default([""]), value)>
—

<#assign isSelected = contains(status.actualValue?default([""]), value)>

292c292
< <#assign isSelected = contains(status.value?default([""]), value)>
—

<#assign isSelected = contains(status.actualValue?default([""]), value)>

[spring-projects-issues]

Chris Beams commented

Rossen, can you please take a look at this? Filippo just posted the following patch via pull request.

https://github.com/cbeams/spring-framework/pull/3

filosganga@067f899