Make MappingJacksonJsonView fields protected to make extending it easier [SPR-7619]

[spring-projects-issues]

Nick Williams opened SPR-7619 and commented

MappingJacksonJsonView is a very simple implementation of a JSON-rendering view. There are many cases where one might need to extend MappingJacksonJsonView to accomplish more complicated tasks. It would be nice if the "objectMapper," "encoding," "prefixJson" and "renderedAttributes" fields could be made protected instead of private to make extending MappingJacksonJsonView a little easier.

Thanks!

---

Affects: 3.0.1

Referenced from: commits f57bc1a

[spring-projects-issues]

Nick Williams commented

Over two years later, nobody has even commented on this bug.

This seems to be a trivial change that I could easily patch. If I take the time to submit this patch, will it be accepted (assuming the patch works, etc.)? Or is there a desire to leave this the way it is?

Is there some documentation somewhere on creating/submitting patches for Spring Framework?

[spring-projects-issues]

Juergen Hoeller commented

Nick, this one got lost in the flood, it seems. Sorry for that.

We generally avoid protected fields but have plenty of cases where we added protected getter methods exactly for the purpose of extensibility...

We'll have a look at this for 3.2.2, next to our more recent MappingJackson2JsonView, keeping them in sync in terms of extensibility.

Juergen

[spring-projects-issues]

Juergen Hoeller commented

MappingJackson(2)JsonView allows subclasses to access the ObjectMapper and the encoding now (in addition to the model keys which have been accessible already), and also to override content writing through the newly extracted writeContent method (receiving stream, value and prefixJson flag as parameters).

Juergen

[spring-projects-issues]

Nick Williams commented

Our particular implementation needs access to objectMapper, encoding, prefixJson and modelKeys. Currently, we are having to override setObjectMapper, setEncoding, setPrefixJson and setModelKey to have duplicate references to those four fields in our class. When we wrote it there was not a getModelKeys method like there is now, so that is a good solution for us there. However, with your change we still have to override setPrefixJson. Any chance we could get it made protected OR get getPrefixJson added?