SpEL: extend set of characters allowed for an identifier [SPR-7100]

[spring-projects-issues]

Andy Clement opened SPR-7100 and commented

Currently the set of characters allowed for an identifier is (if i recall correctly) based on the Spring .net format. This is an alphanumeric followed any number of alphanumerics or underscores.

This is quite restrictive. Mark Fisher is considering using underscore to prefix identifiers used under SI to indicate those that are 'system managed' properties. So the minimum requirement here is to allow the first char to be an underscore. However, we should probably think about what it might mean to follow the java.lang.Character defined: isJavaIdentifierStart/isJavaIdentifierPart. If it doesn't interfere too much with lexing/parsing, we should look to support that format.

---

Affects: 3.0.2

Referenced from: commits f53621a, bf1a95c

[spring-projects-issues]

Andy Clement commented

support for underscore is now in SpEL. Asking Mark F if that is good enough for now. Supporting the full set of allowed characters would make mess of the lexer, mainly due to some of them being already in use with other meanings. For example '$'.

[spring-projects-issues]

Andy Clement commented

added $ support too. work complete