Allowing a flexible reference to JBoss Work Manager [SPR-6648]

[spring-projects-issues]

Matias Urbieta opened SPR-6648 and commented

I'm currently defining different work managers at jboss as for custom concurrency configuration. When i tried to use JBossWorkManagerUtils for resolving the a given work manager, i realized that it only resolves the default work manager published by jboss using JMX technology under "jboss.jca:service=WorkManager" object name.
So i propose the following refactoring where JBossWorkManagerUtils provides two methods:

• getDefaultWorkManager : resolves the default jboss workmanager using "jboss.jca:service=WorkManager" as object name
• getWorkManager(wm) : produces a JMX lookup process using "wm" parameter as workmanager's object name.

The JBossWorkManagerTaskExecutor was refactorized in order to be compliant with the new version of JBossWorkManagerUtils. Additionally a new property was added called "workManagerObjectName" which allows to specify a custom work manager object name that later is used for invoking JBossWorkManagerUtils.getWorkManager method.
[#JBossWorkManagerUtils]
[^JBossWorkManagerTaskExecutor]

---

Affects: 2.5.2, 2.5.3, 2.5.4, 2.5.5, 2.5.6

Attachments:

• JBossWorkManagerTaskExecutor.java (1.47 kB)
• JBossWorkManagerUtils.java (3.10 kB)

Referenced from: commits 2ba1dd4

[spring-projects-issues]

Juergen Hoeller commented

Thanks for the suggestion! I've added such a property in a revised form as a "workManagerMBeanName" property on JBossWorkManagerTaskExecutor.

Juergen

[spring-projects-issues]

Matias Urbieta commented

I just would add and assert at the getWorkManager(String mbeanName)'s beginning like:

Assert.hasLength(mbeanName, "WorkManager's mbeanName can't be null or empty string.");

Regards

[spring-projects-issues]

Juergen Hoeller commented

Good point - I've added such an assertion there.

Juergen