JUnit 4.5 support broken [SPR-5995]

[spring-projects-issues]

Eberhard Wolff opened SPR-5995* and commented

If you use JUnit 4.5 with Spring 3.0M4 you get an exception. At least the MANIFEST.MF for Spring Tests gives [3.8.2, 5.0.0) as the range so it should work I believe

Here is the stack trace:

java.lang.IllegalAccessError: tried to access method org.junit.runners.BlockJUnit4ClassRunner.makeNotifier(Lorg/junit/runners/model/FrameworkMethod;Lorg/junit/runner/notification/RunNotifier;)Lorg/junit/internal/runners/model/EachTestNotifier; from class org.springframework.test.context.junit4.SpringJUnit4ClassRunner
at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:231)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:46)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:180)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:41)
at org.junit.runners.ParentRunner$1.evaluate(ParentRunner.java:173)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
at org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
at org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
at org.junit.runners.ParentRunner.run(ParentRunner.java:220)
at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:179)
at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:46)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)

java.lang.IllegalAccessError: tried to access method org.junit.runners.BlockJUnit4ClassRunner.makeNotifier(Lorg/junit/runners/model/FrameworkMethod;Lorg/junit/runner/notification/RunNotifier;)Lorg/junit/internal/runners/model/EachTestNotifier; from class org.springframework.test.context.junit4.SpringJUnit4ClassRunner
at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:231)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:46)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:180)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:41)
at org.junit.runners.ParentRunner$1.evaluate(ParentRunner.java:173)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
at org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
at org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
at org.junit.runners.ParentRunner.run(ParentRunner.java:220)
at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:179)
at org.junit.runners.Suite.runChild(Suite.java:115)
at org.junit.runners.Suite.runChild(Suite.java:23)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:180)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:41)
at org.junit.runners.ParentRunner$1.evaluate(ParentRunner.java:173)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
at org.junit.runners.ParentRunner.run(ParentRunner.java:220)
at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:46)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)

---

Affects: 3.0 M4

Issue Links:

• Upgrade the Spring TestContext Framework to JUnit 4.7 [SPR-5963] #10631 Upgrade the Spring TestContext Framework to JUnit 4.7

Referenced from: commits 4a7c299, 8fb53c8, da3eb58

3 votes, 3 watchers

[spring-projects-issues]

Dave Syer commented

The manifest is OK, but only 4.6 or better is supported with SpringJUnit4ClassRunner.

[spring-projects-issues]

Juergen Hoeller commented

Spring 3.0 M4 requires JUnit 4.6, and Spring 3.0 RC1 will probably require JUnit 4.7 even. Essentially, the evolution of JUnit 4.x is making our job harder than necessary there. Sam, could you please elaborate on why we are requiring the latest JUnit version now?

Juergen

[spring-projects-issues]

Sam Brannen commented

Hi guys,

I'm including some of the rationale for upgrading from JUnit 4.4 - 4.7, and I would appreciate your thoughts on the matter as well.

JUnit's Runner implementations were not intended for extension until JUnit 4.5. Thus, at the very least, we had to upgrade to 4.5 due to deprecation of the old 4.4-style Runner. JUnit 4.5 brought with it an extensible Statement abstraction which is certainly an improvement over the old MethodRoadie, ClassRoadie, etc. On the downside JUnit 4.5 is not backwards compatible with JUnit 4.4 with regard to Runner internals.

Once we upgraded to 4.5, people asked that we upgrade to 4.6 due to bug fixes in JUnit, etc. (see http://junit.org/node/539). Unfortunately, in the upgrade from 4.5 to 4.6 the JUnit team decided to change the visibility of the makeNotifier(FrameworkMethod, RunNotifier) method in BlockJUnit4ClassRunner from private to protected. This change broke SpringJUnit4ClassRunner's compatibility with JUnit 4.5. Thus as of Spring 3.0.0.M4, JUnit 4.6 is required for SpringJUnit4ClassRunner.

The recent release of JUnit 4.7 includes some bug fixes for 4.6 as well as support for the new Rules abstraction, which is intended to once again completely alter the internals of Runner implementations. JUnit 4.7 also deprecates some of the methods which SpringJUnit4ClassRunner overrides and/or calls. In addition, the JUnit team changed their mind about the visibility of the makeNotifier() method and changed it back to private. Thus the latest snapshots for Spring 3.0.0.RC1 require JUnit 4.7, since Runner internals for 4.7 are not backwards compatible with JUnit 4.6.

As Juergen pointed out, the evolution of JUnit 4.x is wreaking havoc on our ability to provide a stable implementation for SpringJUnit4ClassRunner. Backwards compatibility was broken between every JUnit release from 4.4 - 4.7 inclusive.

Of course, client code (i.e., the actual JUnit 4.x tests you write) should not be affected by these internal changes; however, if you rely on a third-party Runner (e.g., SpringJUnit4ClassRunner) you may be forced to upgrade to a newer version of JUnit 4.x.

Other than forcing developers to upgrade to the latest version of JUnit 4.x, one alternative would be to provide a different Spring Runner for each version of JUnit 4.x, for example: SpringJUnit44ClassRunner, SpringJUnit45ClassRunner, SpringJUnit46ClassRunner, SpringJUnit47ClassRunner, etc. Another, less desirable, alternative would be to completely refactor SpringJUnit4ClassRunner so that it does not rely on any current implementation of JUnit's BlockJUnit4ClassRunner; however, IMHO this would be quite a nightmare in terms of maintenance and adding support for future JUnit features such as Rules, etc.

Thoughts?

Sam

[spring-projects-issues]

Sam Brannen commented

If you use JUnit 4.5 with Spring 3.0M4 you get an exception. At least the MANIFEST.MF for Spring Tests gives [3.8.2, 5.0.0) as the range...

The OSGi manifest version range is at best misleading. Certain parts of the org.springframework.test bundle require JUnit 3.8.2, and certain parts require (as of Spring 3.0.0.RC1 snapshots) 4.7.0. In terms of OSGi, we should probably actually split this functionality into different bundles, but I don't think we actually plan on doing that any time soon. So I guess developers just need to be aware of which JUnit version is required for the actual code they're using in org.springframework.test.

Note: JUnit 4.x also supports running JUnit 3.8.2 TestCases. ;)

So maybe we should change the range from [3.8.2,5.0.0) to [4.7.0,5.0.0).

Thoughts?

• Sam

[spring-projects-issues]

Corrado Alesso commented

Very same issue with Spring 3.0M4 and the new JUnit 4.7.

With JUnit 4.6 it does work.

[spring-projects-issues]

Sam Brannen commented

Corrado,

Spring 3.0.0.M4 requires exactly JUnit 4.6, and Spring 3.0.0.RC1 (i.e., current nightly snapshots) requires exactly JUnit 4.7.

As I mentioned above, the JUnit team broke backwards compatibility between every JUnit release from 4.4 - 4.7 inclusive. This is something which is unfortunately out of our control (unless we re-implement the entire JUnit 4 Runner hierarchy which is undesirable).

Sam

[spring-projects-issues]

Shane Witbeck commented

I have the same issue with a similar stacktrace:

[junit] tried to access method org.junit.runners.BlockJUnit4ClassRunner.makeNotifier(Lorg/junit/runners/model/FrameworkMethod;Lorg/junit/runner/notification/RunNotifier;)Lorg/junit/internal/runners/model/EachTestNotifier; from class org.springframework.test.context.junit4.SpringJUnit4ClassRunner
[junit] at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:231)
[junit] at org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
[junit] at org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
[junit] at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:179)

[spring-projects-issues]

Shane Witbeck commented

Didn't see the previous comments until after I posted mine. All is well after I upgraded to junit 4.6 from 4.5.

[spring-projects-issues]

Sam Brannen commented

Good news: I have come up with a simple work-around in SpringJUnit4ClassRunner that gets us past the compatibility issues between JUnit 4.5 - 4.7!

You should therefore be able to use JUnit 4.5, 4.6, or 4.7 with the Spring TestContext Framework in Spring 3.0.

This change will be available in the next nightly snapshot as well as in the upcoming Spring 3.0.0.RC1 release. So, please give it a try and let us know if you run into any other compatibility issues.

Thanks,

Sam

[spring-projects-issues]

Iwein Fuld commented

Same issue happens with higher versions of JUnit (e.g 4.7.0). Fix confirmed in BUILD-SNAPSHOT.

[spring-projects-issues]

Neale Upstone commented

Mmm... seems that JUnit could do with a little help. Perhaps SpringSource could find some dosh to add it to the portfolio :)

Seriously though, testing is part of the SpringSource brand, so it would be a good fit.

[spring-projects-issues]

Neale Upstone commented

In reply to comment #10:

This change will be available in the next nightly snapshot as well as in the
upcoming Spring 3.0.0.RC1 release. So, please give it a try and let us know if
you run into any other compatibility issues.

Running with JUnit4.6 and Spring 3.0.0.RC1 and all seems fine.
Many thanks Sam.

[spring-projects-issues]

Leandro de Oliveira commented

JUnit 4.7 support is still broken. Stacktrace:

java.lang.IllegalAccessError: tried to access method org.junit.runners.BlockJUnit4ClassRunner.makeNotifier(Lorg/junit/runners/model/FrameworkMethod;Lorg/junit/runner/notification/RunNotifier;)Lorg/junit/internal/runners/model/EachTestNotifier; from class org.springframework.test.context.junit4.SpringJUnit4ClassRunner
at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:231)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
at org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:179)
at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:46)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)

[spring-projects-issues]

Sam Brannen commented

Leandro,

JUnit 4.7 support is not broken.

As of Spring 3.0.0.RC1, SpringJUnit4ClassRunner no longer calls BlockJUnit4ClassRunner's makeNotifier() method. Instead, SpringJUnit4ClassRunner calls its own springMakeNotifier() method.

Thus, you are obviously not running against 3.0.0.RC1. So please check your classpath to verify that you are using the correct version of Spring.

Thanks,

Sam

[spring-projects-issues]

Leandro de Oliveira commented

I was running against M4, sorry.