JdbcAggregateOperations delete by query

[micopiira]

While comparing R2dbcEntityOperations and JdbcAggregateOperations I noticed that R2dbcEntityOperations has a method to delete entities by query: R2dbcEntityOperations#delete(org.springframework.data.relational.core.query.Query,java.lang.Class) but JdbcAggregateOperations does not.

I'm proposing to add following method to the JdbcAggregateOperations interface:

void delete(org.springframework.data.relational.core.query.Query query, Class<?> domainType);

[ivamly]

Hi, @schauder!

Could I work on this? If so, is there any additional information I should know before I start working on it?

Thanks!

[schauder]

Sure, go ahead.

[ivamly]

Hi @schauder ! I just wanted to confirm that my understanding of the implementation is correct. Here's what I think needs to be done:

1. The delete method will be executed via DataAccessStrategy, as all methods that use Query are executed in this way.
2. We need to add a method in SqlGenerator to generate the SQL query for the delete operation.
3. A method needs to be added in SqlParametersFactory to retrieve the parameters based on the provided Query.
4. Finally, we will execute the delete operation via operations.update().

Is my understanding correct? Any advice would be greatly appreciated. Thanks!

[schauder]

Sounds good.

[micopiira]

@ivamly Any progress on this one?

[ivamly]

@micopiira Hi! No, I'm sorry, I don't think I'll be able to do it any time soon.