Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDBC and R2DBC Criteria API documentation mismatch #1841

Closed
mipo256 opened this issue Jul 25, 2024 · 1 comment
Closed

JDBC and R2DBC Criteria API documentation mismatch #1841

mipo256 opened this issue Jul 25, 2024 · 1 comment
Assignees
Labels
type: documentation A documentation update

Comments

@mipo256
Copy link
Contributor

mipo256 commented Jul 25, 2024

Both JDBC and R2DBC modules support dynamic Criteria API, either via JdbcAggregateTemplate or R2dbcEntitytTemplate. It seems rather strange that we mention this in the R2DBC doc, but the exact same section in JDBC doc does not contain any Criteria API mentioning whatsoever. I'm not talking about fluent API as such, but rather about Criteria API usage.

I think we should incorporate a link to Criteria API doc section in R2DBC for Spring Data JDBC documentation, to avoid duplication.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 25, 2024
@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 26, 2024
@schauder
Copy link
Contributor

schauder commented Aug 5, 2024

Thanks for pointing out this gap in our documentation.
I don't think that copying the section about the Criteria API is sufficient.
Instead we should introduce a section about the querying capabilities based on Query in the JdbcAggregateTemplate

schauder added a commit that referenced this issue Aug 12, 2024
schauder added a commit that referenced this issue Aug 14, 2024
@schauder schauder added this to the 3.3.3 (2024.0.3) milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants