Support relationships in find by example #2697
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-simons
requested changes
Mar 22, 2023
Collaborator
michael-simons
left a comment
michael-simons
left a comment
There was a problem hiding this comment.
Just a small nitpicking, very valuable change, nice test.
| String propertyName = graphProperty.getPropertyName(); | ||
| // Right now we are only accepting the first element of a collection as a filter entry. | ||
| // Maybe combining multiple entities with AND might make sense. | ||
| if (relationshipObject instanceof Collection) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (relationshipObject instanceof Collection) { | |
| if (relationshipObject instanceof Collection collection) { |
| // Right now we are only accepting the first element of a collection as a filter entry. | ||
| // Maybe combining multiple entities with AND might make sense. | ||
| if (relationshipObject instanceof Collection) { | ||
| int collectionSize = ((Collection<?>) relationshipObject).size(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| int collectionSize = ((Collection<?>) relationshipObject).size(); | |
| int collectionSize = collection.size(); |
It's possible now to also define fields in the relationships to query for by example. This commit advances the functionality of the PropertyPathWrapper class to also cater for the needs of the Predicate created by the example instance(s). Closes #2696
meistermeier
force-pushed
the
issue/gh2696
branch
from
bfcb8f3 to
24b1556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use the
PropertyPathWrapper, that was only used forPartTree/ derived queries, now for the relationship pattern creation of the find-by-example mechanism.