DATAMONGO-1768 - Allow ignoring type restriction when issuing QBE. #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now allow to remove the type restriction inferred by the QBE mapping via an ignored path expression on the ExampleMatcher. This allows to create untyped QBE expressions returning all entities matching the query without limiting the result to types assignable to the probe itself.
Introducing UntypedExample allows creation of QBE criteria that does not infer a strict type match.
mp911de
pushed a commit
that referenced
this pull request
Aug 25, 2017
We now allow to remove the type restriction inferred by the QBE mapping via an ignored path expression on the ExampleMatcher. This allows to create untyped QBE expressions returning all entities matching the query without limiting the result to types assignable to the probe itself. Original pull request: #496.
mp911de
added a commit
that referenced
this pull request
Aug 25, 2017
Extend javadocs. Make methods static/reorder methods where possible. Formatting. Original pull request: #496.
mp911de
pushed a commit
that referenced
this pull request
Aug 25, 2017
We now allow to remove the type restriction inferred by the QBE mapping via an ignored path expression on the ExampleMatcher. This allows to create untyped QBE expressions returning all entities matching the query without limiting the result to types assignable to the probe itself. Original pull request: #496.
mp911de
pushed a commit
that referenced
this pull request
Aug 25, 2017
Introducing UntypedExampleMatcher allows creation of QBE criteria that does not infer a strict type match. Original pull request: #496.
mp911de
added a commit
that referenced
this pull request
Aug 25, 2017
Use Lombok to generate constructors. Extend javadocs. Make methods static/reorder methods where possible. Use diamond syntax where possible. Formatting. Original pull request: #496.
mp911de
pushed a commit
that referenced
this pull request
Aug 25, 2017
We now allow to remove the type restriction inferred by the QBE mapping via an ignored path expression on the ExampleMatcher. This allows to create untyped QBE expressions returning all entities matching the query without limiting the result to types assignable to the probe itself. Original pull request: #496.
mp911de
added a commit
that referenced
this pull request
Aug 25, 2017
Extend javadocs. Make methods static/reorder methods where possible. Formatting. Original pull request: #496.
|
That's merged, polished and back-ported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now allow to remove the type restriction inferred by the QBE mapping via an ignored path expression on the
ExampleMatcher. This allows to create sort of untyped QBE expressions returning all entities matching the query without limiting the result to types assignable to the probe itself.2fa07bb might be a candidate for back porting to 1.x generation, while 6e9abbf depends on changes in spring-projects/spring-data-commons#238 which opens the API so that creation of an
UntypedExampleis possible.