DATAMONGO-1733 - Allow open/closed interface projections directly via fluent API. #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophstrobl
changed the title
…e is interface.
…target type is interface
…arget type is interface
christophstrobl
force-pushed
the
issue/DATAMONGO-1733
branch
from
0ca294b to
b2e6b59
Compare
odrotbohm
pushed a commit
that referenced
this pull request
Jul 20, 2017
Interfaces based projections handed to queries built using the FluentMongoOperations APIs now get projected as expected and also apply querying optimizations so that only fields needed in the projection are read in the first place. Original pull request: #486.
odrotbohm
pushed a commit
that referenced
this pull request
Jul 20, 2017
…ions. Original pull request: #486.
odrotbohm
added a commit
that referenced
this pull request
Jul 20, 2017
Tiny improvements to the ProjectingReadCallback as we now skip null values completely. Made the ProjectionFactory an instance variable to make sure we propagate the BeanFactory and BeanClassLoader in setApplicationContext(…). Added unit test to verify instances aren't proxied unnecessarily if the interface asked for is already implemented by the target. Original pull request: #486. Related tickets: DATACMNS-1121.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ This is work in progress. Do not merge - needs discussion!
We now directly support open and closed interface projections in the fluent API. For closed interface projections we add the according field list to optimize query execution in those cases where the actual
Querydoes not already define the fields to load/exclude.