DATAMONGO-1721 - Package dependency cycles fixed. #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
force-pushed
the
issue/DATAMONGO-1721
branch
from
7664bbb to
61df936
Compare
Added a Degraph based tests to identify package cycles and violations in layering. Moved Collation to the core.query package, fixing dependency cycles. Moved Index Operations and IndexOperationsProvider to the core.index package. fixing dependency cycles. Moved GeoJsonConfiguration to config package. Replaced the original version of these interfaces/classes with a deprecated version extending the new one, in order to not break the existing API. Removed all references to Part.Type, except for those to maintain the existing API. API using Part.Type is marked as deprecated. It violates the layering, because nothing but "config" should access "repository". Tests added to MongoRegexCreator in order to facilitate the removal of Part.Type dependencies. Using the moved/new ExampleMatcherAccessor. Related Tickets: DATACMNS-1097.
schauder
force-pushed
the
issue/DATAMONGO-1721
branch
from
61df936 to
d4d648a
Compare
|
The test failures are not related to the PR but are generally flaky tests :-( |
odrotbohm
pushed a commit
that referenced
this pull request
Jul 13, 2017
Added a Degraph based tests to identify package cycles and violations in layering. Moved Collation to the core.query package, fixing dependency cycles. Moved IndexOperations and IndexOperationsProvider to the core.index package. fixing dependency cycles. Moved GeoJsonConfiguration to config package. Replaced the original version of these interfaces/classes with a deprecated version extending the new one, in order to not break the existing API. Removed all references to Part.Type, except for those to maintain the existing API. API using Part.Type is marked as deprecated. It violates the layering, because nothing but "config" should access "repository". Tests added to MongoRegexCreator in order to facilitate the removal of Part.Type dependencies. Using the moved/new ExampleMatcherAccessor. Related Tickets: DATACMNS-1097. Original pull request: #470.
odrotbohm
added a commit
that referenced
this pull request
Jul 13, 2017
Removed deprecated types and adapt dependency tests accordingly. Refactored MongoExampleMapper to revert to use StringMatcher from Spring Data Commons' ExampleMatcher. Introduced MongoRegexCreator specific MatchMode, which is basically a copy of StringMatcher. Adapted MongoExampleMapper and MongoQueryCreator to translate from StringMatcher and Part.Type to MatchMode. Turned unit tests for MongoRegexCreator into parameterized ones. Original pull request: #470.
mp911de
added a commit
that referenced
this pull request
Jul 14, 2017
Align with synchronous IndexOperations. Related pull request: #470.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DATAMONGO-1721 - Package dependencies fixed.
Added Degraph based tests to identify package cycles and violations in layering.
Moved Collation to the core.query package, fixing dependency cycles.
Moved Index Operations and IndexOperationsProvider to the core.index package. fixing dependency cycles.
Moved GeoJsonConfiguration to config package.
Copied StringMatcher to be used as a replacement of Part.Type.
Removed all references to Part.Type, except for those to maintain the existing API. API using Part.Type is marked as deprecated. It violates the layering because nothing but "config" should access "repository".
Tests added to MongoRegexCreator in order to facilitate the removal of Part.Type dependencies.
Using the moved/new ExampleMatcherAccessor.
Related Tickets: DATACMNS-1097.
Jira issue: https://jira.spring.io/browse/DATAMONGO-1721.