Skip to content

Allow custom MongoHandlerObservationConvention usage #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
francoiskha wants to merge 2 commits into from
Closed

Allow custom MongoHandlerObservationConvention usage #4607

francoiskha wants to merge 2 commits into from

Conversation

@francoiskha
Copy link
Contributor

@francoiskha francoiskha commented Jan 10, 2024

Hi all,

This is an attempt at fixing #4321.
this is my first PR, please let me know if something is wrong.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@pivotal-cla
Copy link

pivotal-cla commented Jan 10, 2024

@francoiskha Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

pivotal-cla commented Jan 10, 2024

@francoiskha Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 10, 2024
@christophstrobl
Copy link
Member

christophstrobl commented Jan 23, 2024 •
edited
Loading

@francoiskha sorry it takes so long - we'll try to have a closer look soon.

@francoiskha francoiskha changed the title Issue/4321 Allow custom MongoHandlerObservationConvention usage Jan 23, 2024
@christophstrobl
Copy link
Member

christophstrobl commented Feb 8, 2024

LGTM

@christophstrobl christophstrobl added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 8, 2024
@christophstrobl christophstrobl self-assigned this Feb 8, 2024
christophstrobl pushed a commit that referenced this pull request Feb 8, 2024
@francoiskha @christophstrobl
Allow to provide custom MongoHandlerObservationConvention.
ebdffb2 
This commit adds an additional constructor to MongoObservationCommandListener that allows to set a custom MongoHandlerObservationConvention.

Closes: #4321
Original Pull Request: #4607
christophstrobl pushed a commit that referenced this pull request Feb 8, 2024
@francoiskha @christophstrobl
Remove deprecated constructor usage in test.
5db4132 
Original Pull Request: #4607
christophstrobl added a commit that referenced this pull request Feb 8, 2024
@christophstrobl
Polishing.
f052256 
Delegate constructor calls and fix formatting in tests.

Original Pull Request: #4607
@christophstrobl
Copy link
Member

christophstrobl commented Feb 8, 2024

thank you @francoiskha - merged to main development line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@christophstrobl christophstrobl

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@francoiskha @pivotal-cla @christophstrobl @spring-projects-issues