DATAMONGO-1394 - Handle id path for references correctly when using Querydsl. #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare issue branch.
We now allow direct usage path.eq() on id properties of db referenced objects. This allows to write the query as `person.coworker.id.eq(corworker.getId())` instead of `person.coworker.eq(corworker)`. This helps building the query using just the plain id not having to actually create new object wrapping it.
odrotbohm
pushed a commit
that referenced
this pull request
Jul 27, 2016
…s for DBRefs. We now allow direct usage path.eq(…) on id properties of db referenced objects. This allows to write the query as person.coworker.id.eq(coworker.getId()) instead of person.coworker.eq(coworker). This helps building the query using just the plain id not having to actually create new object wrapping it. Original pull request: #373.
odrotbohm
added a commit
that referenced
this pull request
Jul 27, 2016
Some internal refactorings to avoid deeply nested if-clauses. Original pull request: #373.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now allow direct usage
path.eq()on id properties of db referenced objects. This allows to write the query asperson.coworker.id.eq(corworker.getId())instead ofperson.coworker.eq(corworker). This helps building the query using just the plain id not having to actually create new object wrapping it.