DATAMONGO-1118 - MappingMongoConverter uses Converter when reading but not writing Maps. #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t not writing Maps. Prepare issue branch.
…t not writing Maps. We now allow conversions of map keys using CustomConverter implementation as long as the conversion target type is a String.
…t not writing Maps. Simplified potentiallyConvertMapKey in MappingMongoConverter. Fixed typos in CustomConversions. Original pull request: #260.
|
In |
christophstrobl
added a commit
that referenced
this pull request
Jan 6, 2015
…r Map keys, too. We now allow conversions of map keys using custom Converter implementations if the conversion target type is a String. Original pull request: #260.
thomasdarimont
pushed a commit
that referenced
this pull request
Jan 6, 2015
…onverter. Fixed typos in CustomConversions. Original pull request: #260.
odrotbohm
added a commit
that referenced
this pull request
Jan 6, 2015
Created dedicated prepareMapKey(…) method to chain calls to potentiallyConvertMapKey(…) and potentiallyEscapeMapKey(…) and make sure they always get applied in combination. Fixed initial map creation for DBRefs to apply the fixed behavior, too. Original pull request: #260.
christophstrobl
added a commit
that referenced
this pull request
Jan 6, 2015
…r Map keys, too. We now allow conversions of map keys using custom Converter implementations if the conversion target type is a String. Original pull request: #260.
thomasdarimont
pushed a commit
that referenced
this pull request
Jan 6, 2015
…onverter. Fixed typos in CustomConversions. Original pull request: #260.
odrotbohm
added a commit
that referenced
this pull request
Jan 6, 2015
Created dedicated prepareMapKey(…) method to chain calls to potentiallyConvertMapKey(…) and potentiallyEscapeMapKey(…) and make sure they always get applied in combination. Fixed initial map creation for DBRefs to apply the fixed behavior, too. Original pull request: #260.
christophstrobl
added a commit
that referenced
this pull request
Jan 6, 2015
…r Map keys, too. We now allow conversions of map keys using custom Converter implementations if the conversion target type is a String. Original pull request: #260.
thomasdarimont
pushed a commit
that referenced
this pull request
Jan 6, 2015
…onverter. Fixed typos in CustomConversions. Original pull request: #260.
odrotbohm
added a commit
that referenced
this pull request
Jan 6, 2015
Created dedicated prepareMapKey(…) method to chain calls to potentiallyConvertMapKey(…) and potentiallyEscapeMapKey(…) and make sure they always get applied in combination. Fixed initial map creation for DBRefs to apply the fixed behavior, too. Original pull request: #260.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now allow conversions of map keys using
CustomConverterimplementation as long as the conversion target type is aString.