Provide a way to set options on the GridFSBucket instance used in GridFsTemplate [DATAMONGO-2165]

[spring-projects-issues]

ogerardin opened DATAMONGO-2165 and commented

GridFSBucket has a set of configurable options, namely:

• bucketName
• chunkSizeBytes
• disableMD5
• readConcern
• readPreference
• writeConcern

Currently there's no way to set any of these options on the GridFSBucket instance used by GridFsTemplate. The instance is provided by method getGridFs() which just calls GridFSBuckets.create(db) or GridFSBuckets.create(db, bucket) depending if we have a bucket name or not. All options have default values.

An easy and quick fix is to make the GridFsTemplate class extendable, and in particular to make the method getGridFs() overridable so that one could customize the GridFSBucket instance returned by this method using any of the GridFSBucket.withXXX() methods.

Or the GridFsTemplate could use a GridFSBucketFactory, or any other mechanism to allow the customization of the GridFSBucket.

 

---

Affects: 2.1.3 (Lovelace SR3)

Reference URL: https://stackoverflow.com/questions/53728853/how-do-i-disable-gridfs-md5-calculation-in-spring-boot

1 votes, 2 watchers

[spring-projects-issues]

Oliver Drotbohm commented

I suggest to add a GridFsBucketConfigurer interface with a ….configure(GridFsBucket) : GridFsBucket that allows post processing of the default bucket we create and using that from within getGridFs(). We could work with one returning the parameter by default but allow the registration of such a configurer on the template

[spring-projects-issues]

ogerardin commented

Consider that GridFsBucket is immutable: to set options you have to call withXXX() multiple times, which creates a new instance each time.

Given that GridFsTemplate calls getGridFs() for each operation, this might not be very efficient, unless of course the resulting GridFsBucket is cached. 

[spring-projects-issues]

Oliver Drotbohm commented

As GridFsBucket seems to be thread-safe we might be able to share it across multiple lookups. That said, we usually avoid those premature optimizations until we get reliable numbers that the additional technical complexity this introduces makes a significant difference. I'd like to start with the general capability and then – if needed and definitely in a different ticket – explore caching options for GridFsBucket

[spring-projects-issues]

ogerardin commented

Fine with me :)

[spring-projects-issues]

ogerardin commented

1.5 years later, any update on this?

[ogerardin]

4 years later, any update on this?