DATAES-479 - Allow specifying a HighlightBuilder when creating a query. #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jnizet
commented
Aug 9, 2018
jnizet
commented
- You have read the Spring Data contribution guidelines.
- There is a ticket in the bug tracker for the project in our JIRA.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes.
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
xhaggi
reviewed
Aug 23, 2018
| @@ -46,7 +47,8 @@ | |||
| private List<SortBuilder> sortBuilders = new ArrayList<>(); | |||
| private List<FacetRequest> facetRequests = new ArrayList<>(); | |||
| private List<AbstractAggregationBuilder> aggregationBuilders = new ArrayList<>(); | |||
| private HighlightBuilder.Field[] highlightFields; | |||
| private HighlightBuilder highlightBuilder; | |||
| private HighlightBuilder.Field[] highlightFields; | |||
xhaggi
changed the title
xhaggi
reviewed
Aug 23, 2018
| public NativeSearchQueryBuilder withHighlightBuilder(HighlightBuilder highlightBuilder) { | ||
| this.highlightBuilder = highlightBuilder; | ||
| return this; | ||
| } |
There was a problem hiding this comment.
same here, wrong identation
jnizet
force-pushed
the
issue/DATAES-479
branch
from
c832115 to
4e578fb
Compare
|
@xhaggi sorry for the indentation problems. It should be fixed now. |
xhaggi
changed the title
xhaggi
approved these changes
Aug 24, 2018
|
Merged, thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.