DATACMNS-661 - Improvements in SpelAwareProxyProjectionFactory. #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 18, 2015 16:50
Prepare issue branch.
We now allow a SpelExpressionParser to be configured on the SpelAwareProxyProjectionFactory. This parser is then passed on to SpelEvaluatingMethodInterceptor. We also now eagerly pre-parse any SpEL expression in @value annotations upfront. This allows us to have a faster invoke(..) implementation in SpelEvaluatingMethodInterceptor. Original pull request: #118.
thomasdarimont
force-pushed
the
issue/DATACMNS-661
branch
from
0825a92 to
10b8937
Compare
thomasdarimont
pushed a commit
that referenced
this pull request
Mar 19, 2015
We now allow a SpelExpressionParser to be configured on the SpelAwareProxyProjectionFactory. This parser is then passed on to SpelEvaluatingMethodInterceptor. We also now eagerly pre-parse any SpEL expression in @value annotations on methods of the projection interface. This avoids repeated evaluations during the actual method invocations. Original pull request: #118.
odrotbohm
added a commit
that referenced
this pull request
Mar 19, 2015
Removed the ability to configure a custom SpElExpressionParser for now as it's not really part of the performance optimization. Polished assertions in SpelEvaluatingMethodInterceptor. Original pull request: #118.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now allow a
SpelExpressionParserto be configured on theSpelAwareProxyProjectionFactory. This parser is then passed on toSpelEvaluatingMethodInterceptor. We also now eagerly pre-parse any SpEL expression in@Valueannotations upfront. This allows us to have a fasterinvoke(..)implementation inSpelEvaluatingMethodInterceptor.