Remove redundant hibernate-entitymanager dependencies #8433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
priority: normal
type: enhancement
snicoll
added a commit
that referenced
this pull request
Mar 2, 2017
* pr/8433: Remove dependency management for `hibernate-entitymanager`
|
Thanks @vpavic ! |
|
With hindsight, I think this was a mistake as it goes against our policy of being happy to provide dependency management for all of a library's modules. The artifact's still there in 5.2 so I think it still makes sense to provide dependency management for it. If someone tries to use 6.0 instead (no idea if that'll work at runtime) the dependency management for a module that doesn't exist in that version won't do any harm. |
wilkinsona
added
status: declined
|
Actually, we need some of the changes: removing the |
wilkinsona
added a commit
that referenced
this pull request
Mar 6, 2017
This commit reinstates dependency management for hibernate-entitymanager as, while empty, it remains part of Hibernate 5.2.x and people may still have a dependency upon it. It also reinstates the configuration of skipping the jar during TLD scanning so that any application that does depend on hibernate-entitymanager doesn't scan it for TLDs. See gh-8433
wilkinsona
changed the title
hibernate-entitymanager
wilkinsona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
hibernate-entitymanagerwas merged intohibernate-corein Hibernate 5.2 (hibernate-entitymanageris empty artifact present only for backwards compatibility reasons and will be removed in Hibernate 6.0), and with Boot 2.0 supporting Hibernate 5.2 as minimum, dependency management forhibernate-entitymanagershould be removed andhibernate-coreshould be used directly instead.