Skip to content

Conversation

@vpavic
Copy link
Contributor

@vpavic vpavic commented Jan 4, 2017

Since master has moved to Hibernate 5.2 in 943262b, dependency management for hazelcast-hibernate52 should be added.

This artifact originates from the same repository as hazelcast-hibernate5 which is already included in Boot's dependency management so existing hazelcast-hibernate5.version can be reused:

hazelcast-hibernate5 supports Java 6+, Hibernate 5.0.x, Hibernate 5.1.x and Hazelcast 3.7+

hazelcast-hibernate52 supports Java 8, Hibernate 5.2.x and Hazelcast 3.7+

On a sidenote, if Boot 2.0 minimum supported version of Hibernate is indeed 5.2 as indicated by #7586 then perhaps this PR could be expanded to remove dependency management for hazelcast-hibernate4 and hazelcast-hibernate5?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 4, 2017
@wilkinsona
Copy link
Member

Thanks for the PR, @vpavic.

perhaps this PR could be expanded to remove dependency management for hazelcast-hibernate4 and hazelcast-hibernate5?

Yes, please. Aligning with Hibernate 5.2 as a minimum makes sense for 2.0 (I should have done it in #7586).

@vpavic vpavic force-pushed the add-hazelcast-hibernate52 branch from ae9c655 to df1ccf3 Compare January 4, 2017 20:25
@vpavic
Copy link
Contributor Author

vpavic commented Jan 4, 2017

Yes, please.

Done, PR updated.

BTW sorry for the confusion, you did remove hazelcast-hibernate4 from dependency management in 943262b so this PR is now effectively replacing the hazelcast-hibernate5 with hazelcast-hibernate52.

@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 4, 2017
@philwebb philwebb added this to the 2.0.0.M1 milestone Jan 4, 2017
@vpavic vpavic force-pushed the add-hazelcast-hibernate52 branch from df1ccf3 to 51e731d Compare January 4, 2017 20:27
@wilkinsona wilkinsona self-assigned this Jan 24, 2017
wilkinsona added a commit that referenced this pull request Jan 24, 2017
* gh-7869:
  Replace dep mgmt for hazelcast-hiberate5 with hazelcast-hibernate52
@vpavic vpavic deleted the add-hazelcast-hibernate52 branch January 24, 2017 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants