Skip to content

Refactoring for IntAutoConfigurationScanRegistrar #7744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Refactoring for IntAutoConfigurationScanRegistrar #7744

wants to merge 1 commit into from

Conversation

@artembilan
Copy link
Member

To avoid the mocking code for the StandardAnnotationMetadata override IntegrationComponentScanRegistrar.getBasePackages() to return AutoConfigurationPackages.get(this.beanFactory)

See spring-projects/spring-integration#2007

@artembilan
Refactoring for IntAutoConfigurationScanRegistrar
64523d1 
To avoid the mocking code for the `StandardAnnotationMetadata` override  `IntegrationComponentScanRegistrar.getBasePackages()` to return `AutoConfigurationPackages.get(this.beanFactory)`

See spring-projects/spring-integration#2007
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 23, 2016
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 27, 2016
@philwebb philwebb added this to the 1.5.0 milestone Dec 27, 2016
@philwebb
Copy link
Member

We'll need to wait for an updated SI release I guess.

@philwebb philwebb modified the milestones: 1.5.0 RC1, 1.5.0 Dec 27, 2016
@artembilan
Copy link
Member Author

Not sure what you mean, since currently Spring Boot is based on SI B-S: https://github.com/spring-projects/spring-boot/blob/master/spring-boot-dependencies/pom.xml#L154.
So, we are fine to merge this. And only what we need to ping SI team to release Milestone with that fix for an appropriate Spring Boot release.

@philwebb
Copy link
Member

That's master. 1.5.x is currently tied to SI 4.3.6. Is the fix just applicable for SI 5.0?

@artembilan
Copy link
Member Author

Oh! Really confusing.

We talked with you about the proper fix for Spring Boot 2.0 only: spring-projects/spring-integration#2007 (comment).
And that's why I did the fix the only for SI-5.0 and raised this PR only against Boot master.

Forget that my comment about release dates: my idea to apply the fix only for the Boot 2.0.
That's all.
Sorry for the mess.

@philwebb
Copy link
Member

I guess this is just for SI 5.0 so I'll re-target. We'll leave the mocking in Boot 1.5.x.

@philwebb philwebb modified the milestones: 2.0.0, 1.5.0 RC1, 2.0.0.M1 Dec 27, 2016
@philwebb
Copy link
Member

@artembilan Got it, thanks for the fix. Will merge for Boot 2.0.

@wilkinsona wilkinsona self-assigned this Jan 30, 2017
wilkinsona added a commit that referenced this pull request Jan 30, 2017
@wilkinsona
Merge pull request #7744 from Artem Bilan
4e3d606 
* gh-7744:
  Make use of new extensions point in IntegrationComponentScanRegistrar
@wilkinsona wilkinsona added type: task A general task and removed type: enhancement A general enhancement labels Jan 30, 2017
@wilkinsona
Copy link
Member

Thanks, @artembilan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@wilkinsona wilkinsona

Labels

type: task A general task

Projects

None yet

Milestone

2.0.0.M1

Development

Successfully merging this pull request may close these issues.

4 participants

@artembilan @philwebb @wilkinsona @spring-projects-issues