Set embedded test database as primary. #7217
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
I wonder if instead of always marking the embedded one as primary we should instead copy |
philwebb
added
type: bug
|
I considered that but since the only time we create the embedded one is if there was only one (in which case adding primary doesn't do anything) or if there were multiple and it was the primary one. Happy to revise if you think that's better. |
When there are multiple datasources present, make sure that the AutoConfigureTestDatabase annotation marks the embedded source as primary.
philwebb
added a commit
that referenced
this pull request
Oct 31, 2016
* pr/7217: Respect 'primary' flag when replacing databases
|
Thanks, I've reworked the PR a little to copy the flag. This should be in the next 1.4.x release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are multiple datasources present, make sure that the
AutoConfigureTestDatabaseannotation marks the embedded source as primary. Otherwise, it will still swap out the primary source but then theHibernateJpaAutoConfigurationwon't be able to inject theDataSourcebecause there will be 2 beans and neither of them will be marked as primary.