Skip to content

Include warning about machine-wide LiveReload servers in reference docs #7080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

gregturn
Copy link
Contributor

@gregturn gregturn commented Oct 1, 2016

I discovered that while running a Guardfile with LiveReload, all my browser tabs were hooked into it, and NOT into my IDE. The docs said to not run more than one LiveReload server inside my IDE, which I was honoring. But it took a few hours before I realized that all the browser tabs with LiveReload enabled were connected to my documentation-based LiveReload server.

I discovered that while running a Guardfile with LiveReload, all my browser tabs were hooked into it, and NOT into my IDE. The docs said to not run more than one LiveReload server inside my IDE, which I was honoring. But it took a few hours before I realized that all the browser tabs with LiveReload enabled were connected to my documentation-based LiveReload server.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 1, 2016
@philwebb philwebb added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 3, 2016
@philwebb philwebb added this to the 1.4.2 milestone Oct 3, 2016
@bclozel
Copy link
Member

bclozel commented Oct 3, 2016

I'm all for tips in the documentation, but only when they guide developers in their choices or describe how Boot works. The first tip describes a limitation of the livereload support; IMO this new tip underlines a use case that does not happen a lot or isn't strictly relevant to Boot.

Wasn't there a log written by OptionalLiveReloadServer stating that the livereload server couldn't start? Can we improve something here instead?

snicoll added a commit that referenced this pull request Oct 7, 2016
@snicoll snicoll self-assigned this Oct 7, 2016
@snicoll
Copy link
Member

snicoll commented Oct 7, 2016

There is already a WARN in the log if you attempt to start the LiveReload server and another one is running:

2016-10-07 14:17:22.615  WARN 9598 --- [  restartedMain] o.s.b.d.a.OptionalLiveReloadServer       : Unable to start LiveReload server

Thanks for the PR but I don't like the change as it is very specific to a particular use case. I've expanded the note a bit in 9861cb7.

@snicoll snicoll closed this Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants