Skip to content

Update DevToolsProperties to exclude META-INF/build-info.properties file #7002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

candrews
Copy link
Contributor

Prior to this commit any application configured to write META-INF/build-properties
could trigger unexpected application restarts. The problem is particularly
prevalent when using Eclipse M2E in combination with Maven's
spring-boot-maven-plugin build-info goal and Gradle's springBoot buildInfo().

This situation is very similar to #3938 and I fixed it in the same way.

…s` files.

Prior to this commit any application configured to write `META-INF/build-info.properties`
could trigger unexpected application restarts. The problem is particularly
prevalent when using Eclipse M2E in combination with Maven's
`spring-boot-maven-plugin` `build-info` goal and Gradle's `springBoot` `buildInfo()`.
@candrews
Copy link
Contributor Author

I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 22, 2016
snicoll added a commit that referenced this pull request Sep 23, 2016
* pr/7002:
  Exclude `META-INF/build-info.properties` from restart
@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 23, 2016
@snicoll snicoll added this to the 1.4.2 milestone Sep 23, 2016
@snicoll snicoll self-assigned this Sep 23, 2016
@snicoll snicoll closed this in d94eedf Sep 23, 2016
@snicoll
Copy link
Member

snicoll commented Sep 23, 2016

@candrews good catch! A couple of remarks:

  • As much as I appreciate you built your PR based on a branch this was the wrong one. build info was introduced in 1.4 :)
  • There's no need to add the comment regarding the CLA. We've integrated that process in github directly.

Thank you for the pr!

@jheadley
Copy link

jheadley commented Dec 1, 2016

I don't believe this is working and perhaps the issue should be reopened. I am seeing restarts being triggered for META-INF/build-info.properties in Spring Boot 1.4.2 and STS 3.8.2. This is how we have the spring boot maven plugin configured in our project if it matters:

<plugin>
    <groupId>org.springframework.boot</groupId>
    <artifactId>spring-boot-maven-plugin</artifactId>
    <configuration>
        <jvmArguments>-Djava.net.preferIPv4Stack=true -Djava.rmi.server.hostname=localhost -Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=5005</jvmArguments>
        <arguments>
            <argument>--spring.profiles.active=dev</argument>
         </arguments>
    </configuration>
    <executions>
        <execution>
            <goals>
                <goal>repackage</goal>
                <goal>build-info</goal>
            </goals>
        </execution>
     </executions>
</plugin>

@wilkinsona
Copy link
Member

@jeadley We don't re-open issues that have been released. FWIW, I can't reproduce the behaviour you've described. If you'd like us to investigate, please open a new issue with a sample project that reproduces the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants