Validate Spring Session database initializer configuration #6649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
| Jdbc jdbcProperties = this.sessionProperties.getJdbc(); | ||
| if (jdbcProperties.getInitializer().isEnabled()) { | ||
| if (Jdbc.DEFAULT_SCHEMA_LOCATION.equals(jdbcProperties.getSchema()) && | ||
| !Jdbc.DEFAULT_TABLE_NAME.equals(jdbcProperties.getTableName())) { |
There was a problem hiding this comment.
I see no reason to move that business in @PostConstruct. You're not using the state of the (Configuration) class but solely the state of SessionProperties so you could just as well move that in SessionProperties itself if that's an invalid state (more on this later).
This commit adds Spring Session JDBC configuration validation that disables database initializer in case custom table name is configured with default schema.
vpavic
force-pushed
the
improve-session-jdbc-autoconfig
branch
from
394f74c to
4d2d7b0
Compare
|
I've updated the PR according to feedback. |
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Sep 12, 2016
This commit adds Spring Session JDBC configuration validation that disables database initializer in case custom table name is configured with default schema. See gh-6649
snicoll
added a commit
that referenced
this pull request
Sep 12, 2016
* pr/6649: Polish contribution Validate Spring Session database initializer configuration
|
Thanks @vpavic, this is now merged in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Spring Session JDBC configuration validation that disables database initializer in case custom table name is configured with default schema.
Currently, it is possible to set custom table name but leave default schema configuration property. This will either result in an error in runtime since expected table (with custom name) won't be found, or, if user has set up the correct table by some other means, with created unused table.
In both cases the correct approach would be to fail fast and indicate invalid configuration.