Skip to content

Polish Spring Session auto-configuration #6648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

import com.hazelcast.core.HazelcastInstance;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
import org.springframework.context.annotation.Conditional;
Expand All @@ -40,11 +39,11 @@
class HazelcastSessionConfiguration {

@Configuration
public static class SpringBootHazelcastHttpSessionConfiguration
protected static class SpringBootHazelcastHttpSessionConfiguration
extends HazelcastHttpSessionConfiguration {

@Autowired
public void customize(SessionProperties sessionProperties) {
protected SpringBootHazelcastHttpSessionConfiguration(
SessionProperties sessionProperties) {
Integer timeout = sessionProperties.getTimeout();
if (timeout != null) {
setMaxInactiveIntervalInSeconds(timeout);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

import javax.sql.DataSource;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
Expand Down Expand Up @@ -53,11 +52,11 @@ public JdbcSessionDatabaseInitializer jdbcSessionDatabaseInitializer(
}

@Configuration
public static class SpringBootJdbcHttpSessionConfiguration
protected static class SpringBootJdbcHttpSessionConfiguration
extends JdbcHttpSessionConfiguration {

@Autowired
public void customize(SessionProperties sessionProperties) {
protected SpringBootJdbcHttpSessionConfiguration(
SessionProperties sessionProperties) {
Integer timeout = sessionProperties.getTimeout();
if (timeout != null) {
setMaxInactiveIntervalInSeconds(timeout);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

package org.springframework.boot.autoconfigure.session;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
import org.springframework.context.annotation.Conditional;
Expand All @@ -38,11 +37,11 @@
class MongoSessionConfiguration {

@Configuration
public static class SpringBootMongoHttpSessionConfiguration
static class SpringBootMongoHttpSessionConfiguration
extends MongoHttpSessionConfiguration {

@Autowired
public void customize(SessionProperties sessionProperties) {
protected SpringBootMongoHttpSessionConfiguration(
SessionProperties sessionProperties) {
Integer timeout = sessionProperties.getTimeout();
if (timeout != null) {
setMaxInactiveIntervalInSeconds(timeout);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
import org.springframework.context.annotation.Conditional;
Expand Down Expand Up @@ -49,13 +48,13 @@ class RedisSessionConfiguration {
.getLogger(RedisSessionConfiguration.class);

@Configuration
public static class SpringBootRedisHttpSessionConfiguration
protected static class SpringBootRedisHttpSessionConfiguration
extends RedisHttpSessionConfiguration {

private SessionProperties sessionProperties;

@Autowired
public void customize(SessionProperties sessionProperties) {
protected SpringBootRedisHttpSessionConfiguration(
SessionProperties sessionProperties) {
this.sessionProperties = sessionProperties;
Integer timeout = this.sessionProperties.getTimeout();
if (timeout != null) {
Expand Down