Skip to content

Upgrade Flyway 4.0 #5344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Upgrade Flyway 4.0 #5344

wants to merge 1 commit into from

Conversation

@eddumelendez
Copy link
Contributor

See gh-5296

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 6, 2016
wilkinsona
wilkinsona reviewed Mar 7, 2016
View reviewed changes
...ure/src/main/java/org/springframework/boot/autoconfigure/flyway/FlywayAutoConfiguration.java
@Configuration
@ConditionalOnClass(LocalContainerEntityManagerFactoryBean.class)
@ConditionalOnBean(AbstractEntityManagerFactoryBean.class)
protected static class FlywayInitializerJpaDependencyConfiguration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll still need something that's the equivalent of this to ensure that Flyway migrations have been run for Hibernate is initialized.

@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 7, 2016
@wilkinsona wilkinsona added this to the 2.0.0.M1 milestone Mar 7, 2016
@wilkinsona wilkinsona added the status: on-hold We can't start working on this issue yet label Mar 7, 2016
wilkinsona
wilkinsona reviewed Mar 7, 2016
View reviewed changes
...ure/src/main/java/org/springframework/boot/autoconfigure/flyway/FlywayAutoConfiguration.java Outdated
}
if (!CollectionUtils.isEmpty(this.flywayCallbacks)) {
for (FlywayCallback flywayCallback : this.flywayCallbacks) {
flyway.setCallbacks(flywayCallback);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic means that only the last callback will be used. A test that verifies that multiple callbacks are called, and that they're called in a well-defined and predictable order would be useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take a look to fix this. Thanks

@eddumelendez
Copy link
Contributor Author

@wilkinsona I have updated the PR keeping the FlywayMigrationInitializer and FlywayMigrationStrategy

@ptahchiev
Copy link
Contributor

Is there any reason why this cannot be included in 1.4 release train?

@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label Apr 12, 2016
@eddumelendez
Copy link
Contributor Author

PR rebased and now all tests are running ok.

@wilkinsona
Copy link
Member

Is there any reason why this cannot be included in 1.4 release train?

@ptahchiev No specific reason. A new major version suggested to me that there would be breaking changes which, generally speaking, we avoid in minor releases of Boot. If you'd like to see this in 1.4, some research into what the breaking changes are, if indeed there are any, would be very useful.

@ptahchiev
Copy link
Contributor

When upgrading to flyway4 please notice that the ignoreFailedFutureMigrations has been deprecated:

2016-05-03 21:37:00,351 org.flywaydb.core.Flyway [localhost-startStop-1] WARN : ignoreFailedFutureMigration has been deprecated and will be removed in Flyway 5.0. Use the more generic ignoreFutureMigrations instead.
2016-05-03 21:37:00,351 org.flywaydb.core.Flyway [localhost-startStop-1] WARN : ignoreFailedFutureMigration has been deprecated and will be removed in Flyway 5.0. Use the more generic ignoreFutureMigrations instead.

@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label May 11, 2016
@wilkinsona wilkinsona removed the status: on-hold We can't start working on this issue yet label May 26, 2016
@snicoll snicoll mentioned this pull request Nov 29, 2016
Closed
@wilkinsona wilkinsona self-assigned this Jan 30, 2017
wilkinsona added a commit that referenced this pull request Jan 30, 2017
@wilkinsona
Polish "Upgrade to Flyway 4.0"
4ea7dc6 
See gh-5344
wilkinsona added a commit that referenced this pull request Jan 30, 2017
@wilkinsona
Merge pull request #5344 from Eddú Meléndez
95ccd76 
* gh-5344:
  Polish "Upgrade to Flyway 4.0"
  Upgrade to Flyway 4.0
@wilkinsona
Copy link
Member

I've merged this into master. Thanks for yet another PR, @eddumelendez!

@eddumelendez eddumelendez deleted the gh-5296 branch January 17, 2018 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@wilkinsona wilkinsona

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

2.0.0.M1

Development

Successfully merging this pull request may close these issues.

6 participants

@eddumelendez @ptahchiev @wilkinsona @tsachev @philwebb @spring-projects-issues