Fix SSL metrics for dynamically registered bundles#48143
Closed
Colorfulnia wants to merge 1 commit intospring-projects:mainfrom
Closed
Fix SSL metrics for dynamically registered bundles#48143Colorfulnia wants to merge 1 commit intospring-projects:mainfrom
Colorfulnia wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: TerryTaoYY <yueyang.tao@gmail.com>
Member
|
Thanks for the PR, @Colorfulnia. It contains a commit authored by @TerryTaoYY. Judging by the user profiles, I think this may be two different accounts owned by the same person but, AFAIK, we can't accept a PR from one user that contains commits from another user. |
Author
|
@wilkinsona Thank you for let me know, I will re-pull request with a single account. |
Contributor
Thanks for the clarification. I've submitted a new pull request from a single account: #48153. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
SslMeterBinderis constructed, it only registers update handlers for the bundlesreturned by
sslBundles.getBundleNames()at that time. Bundles that are registered lateronly trigger the register handler once and never get an update handler, so subsequent
SslBundleRegistry.updateBundle(...)calls do not refresh thessl.chain.expirygauges.This change updates the register handler to also register an update handler for the
newly registered bundle and adds a regression test:
SslMeterBinderTests.shouldWatchUpdatesForBundlesRegisteredAfterConstructionThe test fails with the original implementation and passes with this change.
Fixes #48144 (gh-48144)