Refine the handling of OpenTelemetry resource attributes #44494
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
nosan
changed the title
nosan
force-pushed
the
gh-44394
branch
4 times, most recently
from
351254a to
2f59144
Compare
Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
|
Another option is to leave things as they are and simply add logic to ignore empty keys.
|
mhalbritter
added
type: task
mhalbritter
pushed a commit
that referenced
this pull request
Mar 3, 2025
See gh-44494 Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
mhalbritter
added a commit
that referenced
this pull request
Mar 3, 2025
|
Thanks @nosan ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #44394
Initially, I considered proposing these changes: main...nosan:spring-boot:gh-44394-1.
However, I eventually realized that it might be too much for this specific case.
This PR aims to eliminate duplications in
OpenTelemetryAutoConfigurationandOtlpMetricsPropertiesConfigAdapter, consolidating everything into a single location.