DataSourceTransactionManagerAutoConfiguration should not enable DataSourceProperties as it does not use them #43603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataSourceProperties bean is not used by DataSourceTransactionManagerAutoConfiguration.
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks @quaff. I think just to be safe, we'll wait until 3.5 to merge this one. I think the extra |
philwebb
added
type: task
wilkinsona
changed the title
wilkinsona
added
type: enhancement
|
I've changed this to an enhancement, primarily so that it will appear in the changelog. |
snicoll
pushed a commit
that referenced
this pull request
Jan 7, 2025
This commit removes the creation of DataSourceProperties in DataSourceTransactionManagerAutoConfiguration as the latter does not use the former. See gh-43603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataSourcePropertiesbean is not used byDataSourceTransactionManagerAutoConfiguration.