Add info contributor support for JDK 24's VirtualThreadSchedulerMXBean #43594
+86
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
reviewed
Dec 23, 2024
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/info/ProcessInfo.java
Outdated
Show resolved
Hide resolved
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/info/ProcessInfo.java
Outdated
Show resolved
Hide resolved
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/info/ProcessInfo.java
Outdated
Show resolved
Hide resolved
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/info/ProcessInfo.java
Outdated
Show resolved
Hide resolved
...g-boot-project/spring-boot/src/test/java/org/springframework/boot/info/ProcessInfoTests.java
Outdated
Show resolved
Hide resolved
...g-boot-project/spring-boot/src/test/java/org/springframework/boot/info/ProcessInfoTests.java
Outdated
Show resolved
Hide resolved
...g-boot-project/spring-boot/src/test/java/org/springframework/boot/info/ProcessInfoTests.java
Outdated
Show resolved
Hide resolved
I think we could add something to the existing test just to check that we have sensible(ish) values. |
philwebb
added
type: enhancement
panic08
force-pushed
the
add-info-contributor-support-for-VirtualThreadSchedulerMXBean
branch
from
6edc540 to
d898b44
Compare
panic08
force-pushed
the
add-info-contributor-support-for-VirtualThreadSchedulerMXBean
branch
from
d898b44 to
1f1b9b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, for applications using Spring with JDK 24, I added support for viewing Virtual threads information in
ProcessInfousingVirtualThreadSchedulerMXBean. The use ofVirtualThreadSchedulerMXBeanis done using reflection. If the current JDK version is less than 24, then we will return null, otherwise a class with all the requiredVirtualThreadsInfoinformation.I also added a test checking if null is returned if the JDK version is less than 24.
There is also a point that bothers me, do you think we need an additional test to check the values of the
VirtualThreadsInfofields themselves or not?Related to #43175