Add Pulsar 4.0.x smoke test #43532
Closed
Add Pulsar 4.0.x smoke test #43532
+292
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a smoke test to verify basic functionality with the Pulsar 4.0.x client.
spring-projects-issues
added
the
status: waiting-for-triage
onobc
commented
Dec 16, 2024
Comment on lines
+8
to
+15
| configurations.all { | ||
| resolutionStrategy.eachDependency { | ||
| if (it.requested.group == 'org.apache.pulsar' && | ||
| !(it.requested.name.startsWith('pulsar-client-reactive'))) { | ||
| it.useVersion '4.0.1' | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I really really do not like the fact that this is 99.98% the same as spring-boot-smoke-test-pulsar. These lines are the ONLY difference between the modules. I wanted to keep this PR simple but if there is an approach already in place to respect DRY that would be a great polish commit on this.
There was a problem hiding this comment.
I think in this case the duplication is fine. The samples aren't published and we can drop this one in Boot 3.5 and just revert to having a single smoke test.
5 tasks
philwebb
added
type: task
philwebb
pushed a commit
that referenced
this pull request
Dec 17, 2024
This commit adds a smoke test to verify basic functionality with the Pulsar 4.0.x client. See gh-43532
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, I missed the fact that the
3.3.3version of Pulsar (which is the version in Boot3.4.xand Spring for Apache Pulsar1.2.x) is the last patch release of the the3.3.xline. The next LTS version is4.0.x.I knew that
4.0.xwas released a few weeks prior to SP1.2.0and SB3.4.0but I missed the detail about it being the last patch release and the team decided not to jump a major version in a minor SB/SP version. Otherwise, I would have recommended that we update to4.0.x.Hindsight is 20/20....
So, this PR adds a compatibility test for users that want to update to Pulsar 4.0.1 client in Spring Boot apps. I have done the same on the Spring for Apache Pulsar framework version 1.2.x and it all works well.
Note
This is the same approach taken for Tomcat 11