Add tests to ensure private constructor is not used for value object binding #42277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
requested changes
Sep 12, 2024
.../src/test/java/org/springframework/boot/context/properties/ConfigurationPropertiesTests.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/springframework/boot/context/properties/ConfigurationPropertiesTests.java
Outdated
Show resolved
Hide resolved
philwebb
changed the title
@Autowired or private constructor is not used for value object binding
quaff
changed the title
quaff
force-pushed
the
patch-68
branch
2 times, most recently
from
1d73939
to
e755d6f
Compare
…binding Sometimes we want to duplicate `@ConfigurationProperties` bean with different prefix, we should use the primary configuration properties as default of additional configuration properties instead of re-configuring them all, then we could inject that primary bean and copy its values as default via constructor, there are two ways to force constructor used for injection instead of binding, annotating it with `@Autowired` or marking it as `private`, and the former one is already covered by tests, this commit add test for latter one.
philwebb
added
type: task
philwebb
pushed a commit
that referenced
this pull request
Sep 13, 2024
|
Thanks @quaff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we want to duplicate
@ConfigurationPropertiesbean with different prefix, we should use the primary configuration properties as default of additional configuration properties instead of re-configuring them all, then we could inject that primary bean and copy its values as default via constructor, there are two ways to force constructor used for injection instead of binding, annotating it with@Autowiredor marking it asprivate, and the former one is already covered by tests, this commit add test for latter one.