Polish gh-40023 #41208
Closed
Polish gh-40023 #41208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
mhalbritter
reviewed
Jun 24, 2024
| @@ -69,14 +67,14 @@ | |||
| before = { CompositeMeterRegistryAutoConfiguration.class, SimpleMetricsExportAutoConfiguration.class }, | |||
| after = { MetricsAutoConfiguration.class, PrometheusMetricsExportAutoConfiguration.class }) | |||
| @ConditionalOnBean(Clock.class) | |||
| @ConditionalOnClass(PrometheusMeterRegistry.class) | |||
| @ConditionalOnClass(io.micrometer.prometheus.PrometheusMeterRegistry.class) | |||
There was a problem hiding this comment.
What's the reason for that change?
There was a problem hiding this comment.
@mhalbritter I just wanted to align with the fully qualified return type of the simpleclientPrometheusMeterRegistry() below and remove the import statement for the PrometheusMeterRegistry that has been deprecated.
There was a problem hiding this comment.
Ah so you switched to fully qualified types to get rid of the deprecated imports.
|
Hey, thanks for the PR, i've added a comment. |
mhalbritter
added
type: task
Closed
mhalbritter
pushed a commit
that referenced
this pull request
Jun 28, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR polishes the changes made in gh-40023 a bit.