Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate support for auto-configuring an embedded ActiveMQ broker #40029

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mattrpav
Copy link
Contributor

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 19, 2024
@mattrpav mattrpav force-pushed the sb-38404 branch 2 times, most recently from 2fb6829 to 31eb469 Compare March 19, 2024 18:21
@mattrpav mattrpav force-pushed the sb-38404 branch 2 times, most recently from 02f7279 to 0024927 Compare March 20, 2024 13:26
@wilkinsona
Copy link
Member

How's it going, @mattrpav? Do you still have plans to finish this off?

@wilkinsona wilkinsona added status: waiting-for-feedback We need additional information before we can continue labels Jun 5, 2024
@mattrpav
Copy link
Contributor Author

@wilkinsona Thanks for the ping. Yes, I plan to get this wrapped up. What is the timeframe to make it in the next Spring Boot release?

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jun 14, 2024
@scottfrederick
Copy link
Contributor

@mattrpav Since this would be considered a feature addition, we would only add it in a new minor release. The next scheduled minor release is 3.4 in November of this year. There will be several milestone releases and a release candidate leading up to the minor version release, which would give users a chance to try it out.

@snicoll
Copy link
Member

snicoll commented Jul 16, 2024

@mattrpav I've looked at what you've done and there's the question of whether we want to reinstate the behavior as it was before. To figure that out, I am happy to look at the various options and polish your proposal. Are you ok with that? We'd like to make sure you haven't wasted time on this.

@snicoll snicoll added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Jul 16, 2024
@mattrpav
Copy link
Contributor Author

@snicoll I have the WIP PR at about 80% and I'll have time to wrap this up soon. A couple ActiveMQ upstream releases are wrapping up, so I can turn my attention to finish this.

Generally, it would seem that providing the like-for-like would ease transition for spring-jms users to make the javax.* to jakarta.* transition. At the same time, improvements always sound compelling, what did you have in mind? Can these be done side-by-side with the existing capabilities and property flags?

I'm hearing from a lot of users that are waiting for this to make the transition to Jakarta-based Spring. A lot of folks have long time investments in ActiveMQ and the other alternatives do not suit their needs.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jul 16, 2024
@snicoll
Copy link
Member

snicoll commented Jul 16, 2024

I have the WIP PR at about 80%

Can you push the code then?

At the same time, improvements always sound compelling, what did you have in mind? Can these be done side-by-side with the existing capabilities and property flags?

I didn't mention improvements. It's figuring out how we get from what we have to this. Right now, Spring Boot 3.x users of ActiveMQ with no configuration would get an infrastructure that connects to an existing broker on localhost using tcp. After this change, it would use an embedded broker in memory. This can be very surprising and we're wondering if that's what we should be doing.

@snicoll snicoll added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Jul 16, 2024
@snicoll
Copy link
Member

snicoll commented Aug 19, 2024

@mattrpav is this PR ready for review now?

@snicoll snicoll added the for: team-meeting An issue we'd like to discuss as a team to make progress label Aug 20, 2024
@philwebb philwebb removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress labels Sep 5, 2024
@philwebb philwebb added the type: enhancement A general enhancement label Sep 5, 2024
@philwebb philwebb added this to the 3.4.x milestone Sep 5, 2024
@snicoll snicoll changed the title WIP: Reinstate support for auto-configuring an embedded ActiveMQ broker Reinstate support for auto-configuring an embedded ActiveMQ broker Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants