Add auto-configuration for SpanAspect #37640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
mhalbritter
added
type: enhancement
|
Hey @jonatan-ivanov, Andy updated to Micrometer Tracing 1.2.0-SNAPSHOT in a630baf If you have the time, could you rebase this PR on top of the lastest |
jonatan-ivanov
force-pushed
the
span-aspect
branch
from
7de5894 to
8292510
Compare
|
@mhalbritter 👍🏼 Done. |
31 tasks
mhalbritter
removed
the
status: blocked
mhalbritter
pushed a commit
that referenced
this pull request
Oct 5, 2023
|
Thanks @jonatan-ivanov ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #35191, this PR adds support for auto-configuring
SpanAspectwhich enables the usage of@NewSpanand@ContinueSpan.The PR depends on changes only available in the latest snapshot of Micrometer Tracing (also
1.2.0-RC1) so it should be blocked until Boot moves toSNAPSHOTorRC1(the first commit does the upgrade).