Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to Atomikos and Bitronix #35562

Conversation

dreis2211
Copy link
Contributor

Hi,

given that both Atomikos and Bitronix support has been removed for a while now, I guess it's fair to remove the remaining references in the metadata.

Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 18, 2023
@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels May 18, 2023
@philwebb philwebb added this to the 3.1.x milestone May 18, 2023
@snicoll
Copy link
Member

snicoll commented May 21, 2023

Actually, I am not sure we should. This serves as hints for those upgrading. Atomikos was removed in 3.0 so it's way too soon to remove it. I think we should rather review the error deprecation that we have and decide when to remove it.

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label May 21, 2023
@dreis2211
Copy link
Contributor Author

Ah fair. Bitronix was deprecated earlier. Atomikos might be a bit too early then. Whatever you decide here, I'm fine with it.

@mhalbritter mhalbritter added status: blocked An issue that's blocked on an external project change status: on-hold We can't start working on this issue yet and removed status: blocked An issue that's blocked on an external project change labels Jun 7, 2023
@wilkinsona
Copy link
Member

We discussed this today and decided that one minor release at error level should be sufficient. For example, Bitronix was deprecated in 2.3. It remained in 2.4 while deprecated and was removed in 2.5. At that time its properties were moved to error level. Under this new policy they would have then be removed in 2.6. In short, we think we can remove the Bitronix metadata immediately (in 3.2).

Atomikos is a little different as it was removed in 3.0 without a period of deprecation as it was a new major. Regardless, we feel that a single minor release at error level is sufficient, particularly given that there are several other signals that the support has been removed such as the loss of the starter. We'll tidy this up in 3.2 as well.

@wilkinsona wilkinsona modified the milestones: 3.1.x, 3.2.x Jul 20, 2023
@wilkinsona wilkinsona added type: documentation A documentation update and removed status: on-hold We can't start working on this issue yet for: team-attention An issue we'd like other members of the team to review type: task A general task labels Jul 20, 2023
@wilkinsona wilkinsona self-assigned this Jul 21, 2023
@wilkinsona wilkinsona modified the milestones: 3.2.x, 3.2.0-M2 Jul 21, 2023
wilkinsona pushed a commit that referenced this pull request Jul 21, 2023
@wilkinsona
Copy link
Member

Thanks very much, @dreis2211.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants