Banner placeholders use default values too soon #34764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
approved these changes
Mar 28, 2023
wilkinsona
added
type: bug
wilkinsona
changed the title
|
Thanks very much, @krzyk. |
wilkinsona
pushed a commit
that referenced
this pull request
Mar 28, 2023
wilkinsona
added a commit
that referenced
this pull request
Mar 28, 2023
edwardsre
reviewed
Apr 24, 2023
| propertySources.addLast(getTitleSource(sourceClass)); | ||
| propertySources.addLast(getAnsiSource()); | ||
| propertySources.addLast(getVersionSource(sourceClass)); | ||
| return Collections.singletonList(new PropertySourcesPropertyResolver(propertySources)); |
There was a problem hiding this comment.
@wilkinsona Using singletonList here changed the behavior of this method by making the returned list unmodifiable. Was this intentional?
For ResourceBanner subclasses, the change to use an unmodifiable list introduced a breaking change. We were able to work around it by creating a new list, adding items from this list, along with our own PropertyResolver(s).
There was a problem hiding this comment.
Good spot. I've fixed that in a707c5e
There was a problem hiding this comment.
Thanks, @edwardsre. I missed that when reviewing the changes.
philwebb
added a commit
that referenced
this pull request
Apr 25, 2023
Reorder methods and add a test to ensure that getPropertyResolvers can be mutated. See gh-34764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #34713.
Fixed support for default value placeholders in banner.
I had to change the way they are handled - replace PropertyResolvers with PropertySources (and add a custom one/anonymous one for Environment).
Added two tests to make sure it really fixed the problem and didn't break in case of missing values.