Configure support for GraphQL pagination and sorting #34677
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @rstoyanchev - here's a first draft for the pagination and sorting support in Spring Boot. Is that what you had in mind? |
rstoyanchev
reviewed
Mar 21, 2023
...e/src/main/java/org/springframework/boot/autoconfigure/graphql/GraphQlAutoConfiguration.java
Show resolved
Hide resolved
This commit auto-configures the new pagination and sorting support for Spring for GraphQL, if Spring Data is available. The `GraphQlAutoConfiguration` now contributes a `CursorStrategy` bean that is used to set up the pagination and sorting data fetching infrastructure. This commit also configures by default a `ConnectionTypeDefinitionConfigurer` that automatically detects `*Connection` types and contributes the relevant schema definitions according to the Relay spec. Closes spring-projectsgh-34630
|
I've just updated my PR with the latest comments. |
wilkinsona
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
LGTM. @rstoyanchev, unless you think some further tweaks are required, we'll try to get this into Thursday's M2 release.
|
Looks good to me as well. Thanks! |
wilkinsona
pushed a commit
that referenced
this pull request
Mar 23, 2023
This commit auto-configures the new pagination and sorting support for Spring for GraphQL, if Spring Data is available. The `GraphQlAutoConfiguration` now contributes a `CursorStrategy` bean that is used to set up the pagination and sorting data fetching infrastructure. This commit also configures by default a `ConnectionTypeDefinitionConfigurer` that automatically detects `*Connection` types and contributes the relevant schema definitions according to the Relay spec. See gh-34677
wilkinsona
added a commit
that referenced
this pull request
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit auto-configures the new pagination and sorting support for
Spring for GraphQL, if Spring Data is available.
The
GraphQlAutoConfigurationnow contributes aCursorStrategybeanthat is used to set up the pagination and sorting data fetching
infrastructure.
This commit also configures by default a
ConnectionTypeDefinitionConfigurerthat automatically detects*Connectiontypes and contributes the relevant schema definitionsaccording to the Relay spec.
Closes gh-34630