Allow JoranConfigurators to be passed ahead of time in logback #33643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: enhancement
mhalbritter
pushed a commit
that referenced
this pull request
Jan 31, 2023
|
Thanks and congrats to your first contribution to Spring Boot! |
|
Regrettably, upon subsequent review we've realised that we made a mistake when accepting these changes. Sorry. The changes only apply during AOT processing which is too specialised and they will also make it harder for us to offer full support for programmatic configuration of Logback in the future (#24992 and #25847). #34361 is tracking the revert which will allow us the time that we need to determine the right way forward here without backing ourselves into a corner. |
wilkinsona
added a commit
that referenced
this pull request
Mar 23, 2023
This reverts commit 25e8f2d, reversing changes made to e5bc9a2. Unfortunately, upon additional review we realised that these changes should not have been accepted. They're a partial implementation of support for programmatically configuring Logback, implemented in a way that only works during AOT processing and also potentially makes it harder for us to implement full support in the future. Closes gh-34361
|
@libetl, have you found a workaround for this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Spring Boot team,
I'm quite new here and I don't know what kind of checklist I need to pass prior to submitting a pull request, sorry about that.
I am trying to understand what kind of changes I am expected to do to use spring-boot 3 in my company.
Logback team has deactivated xml declaration of rules
<newRule>since logback 1.3 for security purposes, so we have to do it programmatically.SpringBootJoranConfiguratordeclares a limited set of rules, so I thought it would be nice to let the user provide its own JoranConfigurators ahead of time.I need that, because I don't want some critical information to be sent in the logs messages.
One of the rule we have in my company is
ObfuscationRule, it is a requirement to have it in spring-boot 3.Thank you for your help.
Related issue (not from me : #24992)
@philwebb would be the one-to-go developper for this item.