Don't modify AliasChecks list from Jetty WebAppContext #29555
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from Jetty WebAppContext Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
|
@lachlan-roberts Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@lachlan-roberts Thank you for signing the Contributor License Agreement! |
bclozel
added
type: task
bclozel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29552
The list returned from
context.getAliasChecks()is not designed to be mutated directly. In later versions of Jetty (10+) this has become an unmodifiable list.This PR changes the usage to instead use the
context.clearAliasChecks()method which also manages theLifeCycleof the alias checker.