Tests that join the server thread in HttpTunnelServerTests may run indefinitely #29522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: task
philwebb
reviewed
Jan 21, 2022
| this.server.handle(this.request, this.response); | ||
| this.serverChannel.disconnect(); | ||
| this.server.getServerThread().join(); | ||
| this.server.getServerThread().join(2000); |
Member
There was a problem hiding this comment.
I wonder if we should extract this to a constant in case we need to tweak the timings later?
Member
There was a problem hiding this comment.
+1. I suspect we'll need longer than two seconds as well for it not to be flaky on CI.
wilkinsona
changed the title
snicoll
pushed a commit
that referenced
this pull request
Jan 31, 2022
snicoll
added a commit
that referenced
this pull request
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue 29502