Skip to content

Warn about the dangers of early bean initialization when using @ConditionalOnExpression #29276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mihailcornescu wants to merge 4 commits into from
Closed

Warn about the dangers of early bean initialization when using @ConditionalOnExpression #29276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e075b4
Warning added in @ConditionalOnExpression value property javadoc
mihailcornescu Jan 5, 2022
0f32a24
added note in adoc file
mihailcornescu Jan 6, 2022
5c40309
ran ./gradlew format command
mihailcornescu Jan 6, 2022
6cbc76c
format javadoc
mihailcornescu Jan 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...c/main/java/org/springframework/boot/autoconfigure/condition/ConditionalOnExpression.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@
/**
* The SpEL expression to evaluate. Expression should return {@code true} if the
* condition passes or {@code false} if it fails.
* <p>
* NOTE: Referencing a bean in the expression will cause that bean to be initialized
* very early in context refresh processing. As a result, the bean will load with
* default property values.
* @return the SpEL expression
*/
String value() default "true";
Expand Down
1 change: 1 addition & 0 deletions .../spring-boot-docs/src/docs/asciidoc/features/developing-auto-configuration.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ This condition will not match for applications that are run with an embedded ser
==== SpEL Expression Conditions
The `@ConditionalOnExpression` annotation lets configuration be included based on the result of a {spring-framework-docs}/core.html#expressions[SpEL expression].

NOTE: Referencing a bean in the expression will cause that bean to be initialized very early in context refresh processing. As a result, the bean will load with default property values.


[[features.developing-auto-configuration.testing]]
Expand Down