Skip to content

The name of the matching-strategy property is incorrect in the action message of the failure analysis for a PatternParseException #28809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
polarbear567 wants to merge 1 commit into from
Closed

The name of the matching-strategy property is incorrect in the action message of the failure analysis for a PatternParseException #28809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../main/java/org/springframework/boot/diagnostics/analyzer/PatternParseFailureAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class PatternParseFailureAnalyzer extends AbstractFailureAnalyzer<PatternParseEx
protected FailureAnalysis analyze(Throwable rootFailure, PatternParseException cause) {
return new FailureAnalysis("Invalid mapping pattern detected: " + cause.toDetailedString(),
"Fix this pattern in your application or switch to the legacy parser implementation with "
+ "'spring.mvc.pathpattern.matching-strategy=ant_path_matcher'.",
+ "'spring.mvc.pathmatch.matching-strategy=ant_path_matcher'.",
cause);
}

Expand Down
2 changes: 1 addition & 1 deletion .../java/org/springframework/boot/diagnostics/analyzer/PatternParseFailureAnalyzerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ void patternParseFailureQuotesPattern() {
assertThat(failureAnalysis.getDescription()).contains("Invalid mapping pattern detected: /spring/**/framework");
assertThat(failureAnalysis.getAction())
.contains("Fix this pattern in your application or switch to the legacy parser"
+ " implementation with 'spring.mvc.pathpattern.matching-strategy=ant_path_matcher'.");
+ " implementation with 'spring.mvc.pathmatch.matching-strategy=ant_path_matcher'.");
}

private FailureAnalysis performAnalysis(String pattern) {
Expand Down